Re: [vdsm] Change in vdsm[master]: vdsm.spec.in: use locale LC_ALL

[Ryan Harper]

* dougsland(a)redhat.com <dougsland(a)redhat.com&gt; [2012-09-19 12:42]:
>  Douglas Schilling Landgraf has uploaded a new change for review.
>  
>  Change subject: vdsm.spec.in: use locale LC_ALL
>  ...................................................................... 
I see that this has already been merged, but a few comments.

>  
>  vdsm.spec.in: use locale LC_ALL
>  
>  During VDSM instalation, we verify if SELinux booleans are 
s/instalation/installation

>  enabled with return of semanage command, output like: "on"
> or "off".
>  These are English words and if the system contains a different
>  locale, example pt_BR the validation will fail.
>  
>  Bug-Id: https://bugzilla.redhat.com/show_bug.cgi?id=857556
>  
>  This patch will change the locale for English (C) while
>  installation VDSM.
>  
>  Change-Id: I22b5706e02c71f463200ce20eb0e426e1bfee6e6
>  Signed-off-by: Douglas Schilling Landgraf <dougsland(a)redhat.com&gt;
>  ---
>  M vdsm.spec.in
>  1 file changed, 5 insertions(+), 0 deletions(-)
>  
>  
>    git pull ssh://gerrit.ovirt.org:29418/vdsm refs/changes/68/8068/1
>  
>  diff --git a/vdsm.spec.in b/vdsm.spec.in
>  index ca678da..41885c2 100644
>  --- a/vdsm.spec.in
>  +++ b/vdsm.spec.in
>  @@ -408,6 +408,9 @@
>   rm -rf %{buildroot}
>   
>   %pre
>  +# Force standard locale behavior (English)
>  +export LC_ALL=C
>  +
>   /usr/bin/getent passwd %{vdsm_user} >/dev/null || \
>       /usr/sbin/useradd -r -u 36 -g %{vdsm_group} -d /var/lib/vdsm \
>           -s /sbin/nologin -c "Node Virtualization Manager" %{vdsm_user}
>  @@ -419,6 +422,7 @@
>   virtNFS=$(/usr/sbin/semanage boolean -l | /bin/grep virt_use_nfs | cut -d ',' -f
> 2)
>   virtSANLOCK=$(/usr/sbin/semanage boolean -l | /bin/grep virt_use_sanlock | cut -d
> ',' -f 2)
>   
>  +# Set the booleans and persist it across reboots 
Either include something in the commit header that says you also added
comments where semanage is used or put these in a separate patch.

>   if [[ "${virtNFS}" == *off* || "${virtSANLOCK}"
> == *off* ]]; then
>       /usr/sbin/semanage boolean -m -S targeted -F /dev/stdin  << _EOF
>   virt_use_nfs=1
>  @@ -426,6 +430,7 @@
>   _EOF
>   fi
>   
>  +# Change the current state of SELinux
>   if /usr/sbin/selinuxenabled; then
>       /usr/sbin/setsebool virt_use_nfs on
>       /usr/sbin/setsebool virt_use_sanlock on
>  
>  
>  --
>  To view, visit http://gerrit.ovirt.org/8068
>  To unsubscribe, visit http://gerrit.ovirt.org/settings
>  
>  Gerrit-MessageType: newchange
>  Gerrit-Change-Id: I22b5706e02c71f463200ce20eb0e426e1bfee6e6
>  Gerrit-PatchSet: 1
>  Gerrit-Project: vdsm
>  Gerrit-Branch: master
>  Gerrit-Owner: Douglas Schilling Landgraf <dougsland(a)redhat.com&gt;
>  _______________________________________________
>  vdsm-patches mailing list
>  vdsm-patches(a)lists.fedorahosted.org
>  https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches 
-- 
Ryan Harper
Software Engineer; Linux Technology Center
IBM Corp., Austin, Tx
ryanh(a)us.ibm.com