3:38 a.m.
Hi all,
While looking at [1], and reading the source of bridge.py of ovirt-hosted-engine-setup
and of ovirt-host-deploy, I think the correct thing will be for addNetwork to not
require either bootproto=dhcp or ipaddr/netmask/etc., but to take this from the existing
conf of the nics to be put inside the bridge.
Does this make sense?
[1] https://bugzilla.redhat.com/show_bug.cgi?id=1013666
Thanks!
--
Didi
3:52 a.m.
----- Original Message -----
From: "Yedidyah Bar David" <didi(a)redhat.com>
To: "vdsm-devel" <vdsm-devel(a)fedorahosted.org>
Cc: "Alon Bar-Lev" <alonbl(a)redhat.com>, "Sandro Bonazzola"
<sbonazzo(a)redhat.com>, "Antoni Segura Puimedon"
<asegurap(a)redhat.com>
Sent: Wednesday, November 27, 2013 10:38:54 AM
Subject: addNetwork to use existing nic conf
Hi all,
While looking at [1], and reading the source of bridge.py of
ovirt-hosted-engine-setup
and of ovirt-host-deploy, I think the correct thing will be for addNetwork to
not
require either bootproto=dhcp or ipaddr/netmask/etc., but to take this from
the existing
conf of the nics to be put inside the bridge.
You mean the addNetwork in vdsm/vdsm/configNetwork.py?
If that is the case I would very much prefer not to make such change, since that
would make addNetwork even farther from referential transparency.
What I propose is that the calling code will use the new getBootProto introduced in:
http://gerrit.ovirt.org/18484 (already merged).
Does this make sense?
[1] https://bugzilla.redhat.com/show_bug.cgi?id=1013666
Thanks!
--
Didi
4:18 a.m.
----- Original Message -----
From: "Antoni Segura Puimedon" <asegurap(a)redhat.com>
To: "Yedidyah Bar David" <didi(a)redhat.com>
Cc: "vdsm-devel" <vdsm-devel(a)fedorahosted.org>, "Alon Bar-Lev"
<alonbl(a)redhat.com>, "Sandro Bonazzola"
<sbonazzo(a)redhat.com>
Sent: Wednesday, November 27, 2013 11:52:51 AM
Subject: Re: addNetwork to use existing nic conf
----- Original Message -----
> From: "Yedidyah Bar David" <didi(a)redhat.com>
> To: "vdsm-devel" <vdsm-devel(a)fedorahosted.org>
> Cc: "Alon Bar-Lev" <alonbl(a)redhat.com>, "Sandro
Bonazzola"
> <sbonazzo(a)redhat.com>, "Antoni Segura Puimedon"
> <asegurap(a)redhat.com>
> Sent: Wednesday, November 27, 2013 10:38:54 AM
> Subject: addNetwork to use existing nic conf
>
> Hi all,
>
> While looking at [1], and reading the source of bridge.py of
> ovirt-hosted-engine-setup
> and of ovirt-host-deploy, I think the correct thing will be for addNetwork
> to
> not
> require either bootproto=dhcp or ipaddr/netmask/etc., but to take this from
> the existing
> conf of the nics to be put inside the bridge.
You mean the addNetwork in vdsm/vdsm/configNetwork.py?
We currently use vdsClient - 'vdsClient addNetwork'.
If that is the case I would very much prefer not to make such change,
since
that
would make addNetwork even farther from referential transparency.
What I propose is that the calling code will use the new getBootProto
introduced in:
http://gerrit.ovirt.org/18484 (already merged).
Does vdsClient support that?
--
Didi
5:55 a.m.
----- Original Message -----
From: "Yedidyah Bar David" <didi(a)redhat.com>
To: "Antoni Segura Puimedon" <asegurap(a)redhat.com>
Cc: "vdsm-devel" <vdsm-devel(a)fedorahosted.org>, "Alon Bar-Lev"
<alonbl(a)redhat.com>, "Sandro Bonazzola"
<sbonazzo(a)redhat.com>
Sent: Wednesday, November 27, 2013 11:18:39 AM
Subject: Re: addNetwork to use existing nic conf
----- Original Message -----
> From: "Antoni Segura Puimedon" <asegurap(a)redhat.com>
> To: "Yedidyah Bar David" <didi(a)redhat.com>
> Cc: "vdsm-devel" <vdsm-devel(a)fedorahosted.org>, "Alon
Bar-Lev"
> <alonbl(a)redhat.com>, "Sandro Bonazzola"
> <sbonazzo(a)redhat.com>
> Sent: Wednesday, November 27, 2013 11:52:51 AM
> Subject: Re: addNetwork to use existing nic conf
>
>
>
> ----- Original Message -----
> > From: "Yedidyah Bar David" <didi(a)redhat.com>
> > To: "vdsm-devel" <vdsm-devel(a)fedorahosted.org>
> > Cc: "Alon Bar-Lev" <alonbl(a)redhat.com>, "Sandro
Bonazzola"
> > <sbonazzo(a)redhat.com>, "Antoni Segura Puimedon"
> > <asegurap(a)redhat.com>
> > Sent: Wednesday, November 27, 2013 10:38:54 AM
> > Subject: addNetwork to use existing nic conf
> >
> > Hi all,
> >
> > While looking at [1], and reading the source of bridge.py of
> > ovirt-hosted-engine-setup
> > and of ovirt-host-deploy, I think the correct thing will be for
> > addNetwork
> > to
> > not
> > require either bootproto=dhcp or ipaddr/netmask/etc., but to take this
> > from
> > the existing
> > conf of the nics to be put inside the bridge.
>
> You mean the addNetwork in vdsm/vdsm/configNetwork.py?
We currently use vdsClient - 'vdsClient addNetwork'.
> If that is the case I would very much prefer not to make such change, since
> that
> would make addNetwork even farther from referential transparency.
>
> What I propose is that the calling code will use the new getBootProto
> introduced in:
> http://gerrit.ovirt.org/18484 (already merged).
Does vdsClient support that?
Well, vdsClient getVdsCaps returns the cfg information for all the devices,
part of that will be the bootproto if it is defined on the ifcfg file of the
device.
--
Didi
6:22 a.m.
On Wed, Nov 27, 2013 at 06:55:26AM -0500, Antoni Segura Puimedon wrote:
----- Original Message -----
> From: "Yedidyah Bar David" <didi(a)redhat.com>
> To: "Antoni Segura Puimedon" <asegurap(a)redhat.com>
> Cc: "vdsm-devel" <vdsm-devel(a)fedorahosted.org>, "Alon
Bar-Lev" <alonbl(a)redhat.com>, "Sandro Bonazzola"
> <sbonazzo(a)redhat.com>
> Sent: Wednesday, November 27, 2013 11:18:39 AM
> Subject: Re: addNetwork to use existing nic conf
>
> ----- Original Message -----
> > From: "Antoni Segura Puimedon" <asegurap(a)redhat.com>
> > To: "Yedidyah Bar David" <didi(a)redhat.com>
> > Cc: "vdsm-devel" <vdsm-devel(a)fedorahosted.org>, "Alon
Bar-Lev"
> > <alonbl(a)redhat.com>, "Sandro Bonazzola"
> > <sbonazzo(a)redhat.com>
> > Sent: Wednesday, November 27, 2013 11:52:51 AM
> > Subject: Re: addNetwork to use existing nic conf
> >
> >
> >
> > ----- Original Message -----
> > > From: "Yedidyah Bar David" <didi(a)redhat.com>
> > > To: "vdsm-devel" <vdsm-devel(a)fedorahosted.org>
> > > Cc: "Alon Bar-Lev" <alonbl(a)redhat.com>, "Sandro
Bonazzola"
> > > <sbonazzo(a)redhat.com>, "Antoni Segura Puimedon"
> > > <asegurap(a)redhat.com>
> > > Sent: Wednesday, November 27, 2013 10:38:54 AM
> > > Subject: addNetwork to use existing nic conf
> > >
> > > Hi all,
> > >
> > > While looking at [1], and reading the source of bridge.py of
> > > ovirt-hosted-engine-setup
> > > and of ovirt-host-deploy, I think the correct thing will be for
> > > addNetwork
> > > to
> > > not
> > > require either bootproto=dhcp or ipaddr/netmask/etc., but to take this
> > > from
> > > the existing
> > > conf of the nics to be put inside the bridge.
> >
> > You mean the addNetwork in vdsm/vdsm/configNetwork.py?
>
> We currently use vdsClient - 'vdsClient addNetwork'.
>
> > If that is the case I would very much prefer not to make such change, since
> > that
> > would make addNetwork even farther from referential transparency.
> >
> > What I propose is that the calling code will use the new getBootProto
> > introduced in:
> > http://gerrit.ovirt.org/18484 (already merged).
>
> Does vdsClient support that?
Well, vdsClient getVdsCaps returns the cfg information for all the devices,
part of that will be the bootproto if it is defined on the ifcfg file of the
device.
We'd very much like to drop the 'cfg' element reported per nic (it
breaks Vdsm's "network" abrstraction and would be anoying to maintain
with iproute2 when we move to it. "BOOTPROTO" is there, and would have
to stay there (for backward compatibility with Engine), but please avoid
using any other data.
Dan.
6:28 a.m.
----- Original Message -----
From: "Dan Kenigsberg" <danken(a)redhat.com>
To: "Antoni Segura Puimedon" <asegurap(a)redhat.com>
Cc: "Yedidyah Bar David" <didi(a)redhat.com>, "vdsm-devel"
<vdsm-devel(a)fedorahosted.org>
Sent: Wednesday, November 27, 2013 1:22:47 PM
Subject: Re: [vdsm] addNetwork to use existing nic conf
On Wed, Nov 27, 2013 at 06:55:26AM -0500, Antoni Segura Puimedon wrote:
>
>
> ----- Original Message -----
> > From: "Yedidyah Bar David" <didi(a)redhat.com>
> > To: "Antoni Segura Puimedon" <asegurap(a)redhat.com>
> > Cc: "vdsm-devel" <vdsm-devel(a)fedorahosted.org>, "Alon
Bar-Lev"
> > <alonbl(a)redhat.com>, "Sandro Bonazzola"
> > <sbonazzo(a)redhat.com>
> > Sent: Wednesday, November 27, 2013 11:18:39 AM
> > Subject: Re: addNetwork to use existing nic conf
> >
> > ----- Original Message -----
> > > From: "Antoni Segura Puimedon" <asegurap(a)redhat.com>
> > > To: "Yedidyah Bar David" <didi(a)redhat.com>
> > > Cc: "vdsm-devel" <vdsm-devel(a)fedorahosted.org>, "Alon
Bar-Lev"
> > > <alonbl(a)redhat.com>, "Sandro Bonazzola"
> > > <sbonazzo(a)redhat.com>
> > > Sent: Wednesday, November 27, 2013 11:52:51 AM
> > > Subject: Re: addNetwork to use existing nic conf
> > >
> > >
> > >
> > > ----- Original Message -----
> > > > From: "Yedidyah Bar David" <didi(a)redhat.com>
> > > > To: "vdsm-devel" <vdsm-devel(a)fedorahosted.org>
> > > > Cc: "Alon Bar-Lev" <alonbl(a)redhat.com>, "Sandro
Bonazzola"
> > > > <sbonazzo(a)redhat.com>, "Antoni Segura Puimedon"
> > > > <asegurap(a)redhat.com>
> > > > Sent: Wednesday, November 27, 2013 10:38:54 AM
> > > > Subject: addNetwork to use existing nic conf
> > > >
> > > > Hi all,
> > > >
> > > > While looking at [1], and reading the source of bridge.py of
> > > > ovirt-hosted-engine-setup
> > > > and of ovirt-host-deploy, I think the correct thing will be for
> > > > addNetwork
> > > > to
> > > > not
> > > > require either bootproto=dhcp or ipaddr/netmask/etc., but to take
> > > > this
> > > > from
> > > > the existing
> > > > conf of the nics to be put inside the bridge.
> > >
> > > You mean the addNetwork in vdsm/vdsm/configNetwork.py?
> >
> > We currently use vdsClient - 'vdsClient addNetwork'.
> >
> > > If that is the case I would very much prefer not to make such change,
> > > since
> > > that
> > > would make addNetwork even farther from referential transparency.
> > >
> > > What I propose is that the calling code will use the new getBootProto
> > > introduced in:
> > > http://gerrit.ovirt.org/18484 (already merged).
> >
> > Does vdsClient support that?
>
> Well, vdsClient getVdsCaps returns the cfg information for all the devices,
> part of that will be the bootproto if it is defined on the ifcfg file of
> the
> device.
We'd very much like to drop the 'cfg' element reported per nic (it
breaks Vdsm's "network" abrstraction and would be anoying to maintain
with iproute2 when we move to it. "BOOTPROTO" is there, and would have
to stay there (for backward compatibility with Engine), but please avoid
using any other data.
Well, for installation time, there must be something (not necessarily part of
vdsm proper that is able to get the ip configuration of the device we connect
through.
Since it could be ifcfg info (el6), NM (newer distros), /etc/network/interfaces
(debian derived) I would really make a separate solution to vdsm.
Dan.
6:51 a.m.
On Wed, Nov 27, 2013 at 07:28:23AM -0500, Antoni Segura Puimedon wrote:
----- Original Message -----
> From: "Dan Kenigsberg" <danken(a)redhat.com>
> To: "Antoni Segura Puimedon" <asegurap(a)redhat.com>
> Cc: "Yedidyah Bar David" <didi(a)redhat.com>, "vdsm-devel"
<vdsm-devel(a)fedorahosted.org>
> Sent: Wednesday, November 27, 2013 1:22:47 PM
> Subject: Re: [vdsm] addNetwork to use existing nic conf
>
> On Wed, Nov 27, 2013 at 06:55:26AM -0500, Antoni Segura Puimedon wrote:
> >
> >
> > ----- Original Message -----
> > > From: "Yedidyah Bar David" <didi(a)redhat.com>
> > > To: "Antoni Segura Puimedon" <asegurap(a)redhat.com>
> > > Cc: "vdsm-devel" <vdsm-devel(a)fedorahosted.org>, "Alon
Bar-Lev"
> > > <alonbl(a)redhat.com>, "Sandro Bonazzola"
> > > <sbonazzo(a)redhat.com>
> > > Sent: Wednesday, November 27, 2013 11:18:39 AM
> > > Subject: Re: addNetwork to use existing nic conf
> > >
> > > ----- Original Message -----
> > > > From: "Antoni Segura Puimedon" <asegurap(a)redhat.com>
> > > > To: "Yedidyah Bar David" <didi(a)redhat.com>
> > > > Cc: "vdsm-devel" <vdsm-devel(a)fedorahosted.org>,
"Alon Bar-Lev"
> > > > <alonbl(a)redhat.com>, "Sandro Bonazzola"
> > > > <sbonazzo(a)redhat.com>
> > > > Sent: Wednesday, November 27, 2013 11:52:51 AM
> > > > Subject: Re: addNetwork to use existing nic conf
> > > >
> > > >
> > > >
> > > > ----- Original Message -----
> > > > > From: "Yedidyah Bar David" <didi(a)redhat.com>
> > > > > To: "vdsm-devel" <vdsm-devel(a)fedorahosted.org>
> > > > > Cc: "Alon Bar-Lev" <alonbl(a)redhat.com>,
"Sandro Bonazzola"
> > > > > <sbonazzo(a)redhat.com>, "Antoni Segura Puimedon"
> > > > > <asegurap(a)redhat.com>
> > > > > Sent: Wednesday, November 27, 2013 10:38:54 AM
> > > > > Subject: addNetwork to use existing nic conf
> > > > >
> > > > > Hi all,
> > > > >
> > > > > While looking at [1], and reading the source of bridge.py of
> > > > > ovirt-hosted-engine-setup
> > > > > and of ovirt-host-deploy, I think the correct thing will be for
> > > > > addNetwork
> > > > > to
> > > > > not
> > > > > require either bootproto=dhcp or ipaddr/netmask/etc., but to
take
> > > > > this
> > > > > from
> > > > > the existing
> > > > > conf of the nics to be put inside the bridge.
> > > >
> > > > You mean the addNetwork in vdsm/vdsm/configNetwork.py?
> > >
> > > We currently use vdsClient - 'vdsClient addNetwork'.
> > >
> > > > If that is the case I would very much prefer not to make such
change,
> > > > since
> > > > that
> > > > would make addNetwork even farther from referential transparency.
> > > >
> > > > What I propose is that the calling code will use the new
getBootProto
> > > > introduced in:
> > > > http://gerrit.ovirt.org/18484 (already merged).
> > >
> > > Does vdsClient support that?
> >
> > Well, vdsClient getVdsCaps returns the cfg information for all the devices,
> > part of that will be the bootproto if it is defined on the ifcfg file of
> > the
> > device.
>
> We'd very much like to drop the 'cfg' element reported per nic (it
> breaks Vdsm's "network" abrstraction and would be anoying to maintain
> with iproute2 when we move to it. "BOOTPROTO" is there, and would have
> to stay there (for backward compatibility with Engine), but please avoid
> using any other data.
Well, for installation time, there must be something (not necessarily part of
vdsm proper that is able to get the ip configuration of the device we connect
through.
Since it could be ifcfg info (el6), NM (newer distros), /etc/network/interfaces
(debian derived) I would really make a separate solution to vdsm.
No doubt about that:
Bug 987813 - [RFE] report BOOTPROTO and BONDING_OPTS independent of
netdevice.cfg
8:47 a.m.
----- Original Message -----
From: "Dan Kenigsberg" <danken(a)redhat.com>
To: "Antoni Segura Puimedon" <asegurap(a)redhat.com>
Cc: "Yedidyah Bar David" <didi(a)redhat.com>, "vdsm-devel"
<vdsm-devel(a)fedorahosted.org>
Sent: Wednesday, November 27, 2013 2:51:37 PM
Subject: Re: [vdsm] addNetwork to use existing nic conf
On Wed, Nov 27, 2013 at 07:28:23AM -0500, Antoni Segura Puimedon wrote:
>
>
> ----- Original Message -----
> > From: "Dan Kenigsberg" <danken(a)redhat.com>
> > To: "Antoni Segura Puimedon" <asegurap(a)redhat.com>
> > Cc: "Yedidyah Bar David" <didi(a)redhat.com>,
"vdsm-devel"
> > <vdsm-devel(a)fedorahosted.org>
> > Sent: Wednesday, November 27, 2013 1:22:47 PM
> > Subject: Re: [vdsm] addNetwork to use existing nic conf
> >
> > On Wed, Nov 27, 2013 at 06:55:26AM -0500, Antoni Segura Puimedon wrote:
> > >
> > >
> > > ----- Original Message -----
> > > > From: "Yedidyah Bar David" <didi(a)redhat.com>
> > > > To: "Antoni Segura Puimedon" <asegurap(a)redhat.com>
> > > > Cc: "vdsm-devel" <vdsm-devel(a)fedorahosted.org>,
"Alon Bar-Lev"
> > > > <alonbl(a)redhat.com>, "Sandro Bonazzola"
> > > > <sbonazzo(a)redhat.com>
> > > > Sent: Wednesday, November 27, 2013 11:18:39 AM
> > > > Subject: Re: addNetwork to use existing nic conf
> > > >
> > > > ----- Original Message -----
> > > > > From: "Antoni Segura Puimedon"
<asegurap(a)redhat.com>
> > > > > To: "Yedidyah Bar David" <didi(a)redhat.com>
> > > > > Cc: "vdsm-devel" <vdsm-devel(a)fedorahosted.org>,
"Alon Bar-Lev"
> > > > > <alonbl(a)redhat.com>, "Sandro Bonazzola"
> > > > > <sbonazzo(a)redhat.com>
> > > > > Sent: Wednesday, November 27, 2013 11:52:51 AM
> > > > > Subject: Re: addNetwork to use existing nic conf
> > > > >
> > > > >
> > > > >
> > > > > ----- Original Message -----
> > > > > > From: "Yedidyah Bar David"
<didi(a)redhat.com>
> > > > > > To: "vdsm-devel"
<vdsm-devel(a)fedorahosted.org>
> > > > > > Cc: "Alon Bar-Lev" <alonbl(a)redhat.com>,
"Sandro Bonazzola"
> > > > > > <sbonazzo(a)redhat.com>, "Antoni Segura
Puimedon"
> > > > > > <asegurap(a)redhat.com>
> > > > > > Sent: Wednesday, November 27, 2013 10:38:54 AM
> > > > > > Subject: addNetwork to use existing nic conf
> > > > > >
> > > > > > Hi all,
> > > > > >
> > > > > > While looking at [1], and reading the source of bridge.py
of
> > > > > > ovirt-hosted-engine-setup
> > > > > > and of ovirt-host-deploy, I think the correct thing will be
for
> > > > > > addNetwork
> > > > > > to
> > > > > > not
> > > > > > require either bootproto=dhcp or ipaddr/netmask/etc., but
to take
> > > > > > this
> > > > > > from
> > > > > > the existing
> > > > > > conf of the nics to be put inside the bridge.
> > > > >
> > > > > You mean the addNetwork in vdsm/vdsm/configNetwork.py?
> > > >
> > > > We currently use vdsClient - 'vdsClient addNetwork'.
> > > >
> > > > > If that is the case I would very much prefer not to make such
> > > > > change,
> > > > > since
> > > > > that
> > > > > would make addNetwork even farther from referential
transparency.
> > > > >
> > > > > What I propose is that the calling code will use the new
> > > > > getBootProto
> > > > > introduced in:
> > > > > http://gerrit.ovirt.org/18484 (already merged).
> > > >
> > > > Does vdsClient support that?
> > >
> > > Well, vdsClient getVdsCaps returns the cfg information for all the
> > > devices,
> > > part of that will be the bootproto if it is defined on the ifcfg file
> > > of
> > > the
> > > device.
> >
> > We'd very much like to drop the 'cfg' element reported per nic (it
> > breaks Vdsm's "network" abrstraction and would be anoying to
maintain
> > with iproute2 when we move to it. "BOOTPROTO" is there, and would
have
> > to stay there (for backward compatibility with Engine), but please avoid
> > using any other data.
>
> Well, for installation time, there must be something (not necessarily part
> of
> vdsm proper that is able to get the ip configuration of the device we
> connect
> through.
>
> Since it could be ifcfg info (el6), NM (newer distros),
> /etc/network/interfaces
> (debian derived) I would really make a separate solution to vdsm.
No doubt about that:
Bug 987813 - [RFE] report BOOTPROTO and BONDING_OPTS independent of
netdevice.cfg
Sorry, I did not understand. Should I or should I not rely on getVdsCaps
to get the ipaddr/netmask/gateway/whatever? Just getting bootproto from it
does not help much if I have to read ifcfg files anyway.
--
Didi
8:54 a.m.
----- Original Message -----
From: "Yedidyah Bar David" <didi(a)redhat.com>
To: "Dan Kenigsberg" <danken(a)redhat.com>
Cc: "Antoni Segura Puimedon" <asegurap(a)redhat.com>,
"vdsm-devel" <vdsm-devel(a)fedorahosted.org>
Sent: Wednesday, November 27, 2013 3:47:20 PM
Subject: Re: [vdsm] addNetwork to use existing nic conf
----- Original Message -----
> From: "Dan Kenigsberg" <danken(a)redhat.com>
> To: "Antoni Segura Puimedon" <asegurap(a)redhat.com>
> Cc: "Yedidyah Bar David" <didi(a)redhat.com>, "vdsm-devel"
> <vdsm-devel(a)fedorahosted.org>
> Sent: Wednesday, November 27, 2013 2:51:37 PM
> Subject: Re: [vdsm] addNetwork to use existing nic conf
>
> On Wed, Nov 27, 2013 at 07:28:23AM -0500, Antoni Segura Puimedon wrote:
> >
> >
> > ----- Original Message -----
> > > From: "Dan Kenigsberg" <danken(a)redhat.com>
> > > To: "Antoni Segura Puimedon" <asegurap(a)redhat.com>
> > > Cc: "Yedidyah Bar David" <didi(a)redhat.com>,
"vdsm-devel"
> > > <vdsm-devel(a)fedorahosted.org>
> > > Sent: Wednesday, November 27, 2013 1:22:47 PM
> > > Subject: Re: [vdsm] addNetwork to use existing nic conf
> > >
> > > On Wed, Nov 27, 2013 at 06:55:26AM -0500, Antoni Segura Puimedon wrote:
> > > >
> > > >
> > > > ----- Original Message -----
> > > > > From: "Yedidyah Bar David" <didi(a)redhat.com>
> > > > > To: "Antoni Segura Puimedon"
<asegurap(a)redhat.com>
> > > > > Cc: "vdsm-devel" <vdsm-devel(a)fedorahosted.org>,
"Alon Bar-Lev"
> > > > > <alonbl(a)redhat.com>, "Sandro Bonazzola"
> > > > > <sbonazzo(a)redhat.com>
> > > > > Sent: Wednesday, November 27, 2013 11:18:39 AM
> > > > > Subject: Re: addNetwork to use existing nic conf
> > > > >
> > > > > ----- Original Message -----
> > > > > > From: "Antoni Segura Puimedon"
<asegurap(a)redhat.com>
> > > > > > To: "Yedidyah Bar David" <didi(a)redhat.com>
> > > > > > Cc: "vdsm-devel"
<vdsm-devel(a)fedorahosted.org>, "Alon Bar-Lev"
> > > > > > <alonbl(a)redhat.com>, "Sandro Bonazzola"
> > > > > > <sbonazzo(a)redhat.com>
> > > > > > Sent: Wednesday, November 27, 2013 11:52:51 AM
> > > > > > Subject: Re: addNetwork to use existing nic conf
> > > > > >
> > > > > >
> > > > > >
> > > > > > ----- Original Message -----
> > > > > > > From: "Yedidyah Bar David"
<didi(a)redhat.com>
> > > > > > > To: "vdsm-devel"
<vdsm-devel(a)fedorahosted.org>
> > > > > > > Cc: "Alon Bar-Lev"
<alonbl(a)redhat.com>, "Sandro Bonazzola"
> > > > > > > <sbonazzo(a)redhat.com>, "Antoni Segura
Puimedon"
> > > > > > > <asegurap(a)redhat.com>
> > > > > > > Sent: Wednesday, November 27, 2013 10:38:54 AM
> > > > > > > Subject: addNetwork to use existing nic conf
> > > > > > >
> > > > > > > Hi all,
> > > > > > >
> > > > > > > While looking at [1], and reading the source of
bridge.py of
> > > > > > > ovirt-hosted-engine-setup
> > > > > > > and of ovirt-host-deploy, I think the correct thing
will be for
> > > > > > > addNetwork
> > > > > > > to
> > > > > > > not
> > > > > > > require either bootproto=dhcp or ipaddr/netmask/etc.,
but to
> > > > > > > take
> > > > > > > this
> > > > > > > from
> > > > > > > the existing
> > > > > > > conf of the nics to be put inside the bridge.
> > > > > >
> > > > > > You mean the addNetwork in vdsm/vdsm/configNetwork.py?
> > > > >
> > > > > We currently use vdsClient - 'vdsClient addNetwork'.
> > > > >
> > > > > > If that is the case I would very much prefer not to make
such
> > > > > > change,
> > > > > > since
> > > > > > that
> > > > > > would make addNetwork even farther from referential
transparency.
> > > > > >
> > > > > > What I propose is that the calling code will use the new
> > > > > > getBootProto
> > > > > > introduced in:
> > > > > > http://gerrit.ovirt.org/18484 (already merged).
> > > > >
> > > > > Does vdsClient support that?
> > > >
> > > > Well, vdsClient getVdsCaps returns the cfg information for all the
> > > > devices,
> > > > part of that will be the bootproto if it is defined on the ifcfg
file
> > > > of
> > > > the
> > > > device.
> > >
> > > We'd very much like to drop the 'cfg' element reported per nic
(it
> > > breaks Vdsm's "network" abrstraction and would be anoying to
maintain
> > > with iproute2 when we move to it. "BOOTPROTO" is there, and
would have
> > > to stay there (for backward compatibility with Engine), but please
> > > avoid
> > > using any other data.
> >
> > Well, for installation time, there must be something (not necessarily
> > part
> > of
> > vdsm proper that is able to get the ip configuration of the device we
> > connect
> > through.
> >
> > Since it could be ifcfg info (el6), NM (newer distros),
> > /etc/network/interfaces
> > (debian derived) I would really make a separate solution to vdsm.
>
> No doubt about that:
> Bug 987813 - [RFE] report BOOTPROTO and BONDING_OPTS independent of
> netdevice.cfg
>
Sorry, I did not understand. Should I or should I not rely on getVdsCaps
to get the ipaddr/netmask/gateway/whatever? Just getting bootproto from it
does not help much if I have to read ifcfg files anyway.
getVdsCaps as it stands now is only working on el6 and Fedora for getting the
bootProto in the cfg field.
--
Didi
9:03 a.m.
----- Original Message -----
From: "Antoni Segura Puimedon" <asegurap(a)redhat.com>
To: "Yedidyah Bar David" <didi(a)redhat.com>
Cc: "Dan Kenigsberg" <danken(a)redhat.com>, "vdsm-devel"
<vdsm-devel(a)fedorahosted.org>
Sent: Wednesday, November 27, 2013 4:54:06 PM
Subject: Re: [vdsm] addNetwork to use existing nic conf
----- Original Message -----
> From: "Yedidyah Bar David" <didi(a)redhat.com>
> To: "Dan Kenigsberg" <danken(a)redhat.com>
> Cc: "Antoni Segura Puimedon" <asegurap(a)redhat.com>,
"vdsm-devel"
> <vdsm-devel(a)fedorahosted.org>
> Sent: Wednesday, November 27, 2013 3:47:20 PM
> Subject: Re: [vdsm] addNetwork to use existing nic conf
>
> ----- Original Message -----
> > From: "Dan Kenigsberg" <danken(a)redhat.com>
> > To: "Antoni Segura Puimedon" <asegurap(a)redhat.com>
> > Cc: "Yedidyah Bar David" <didi(a)redhat.com>,
"vdsm-devel"
> > <vdsm-devel(a)fedorahosted.org>
> > Sent: Wednesday, November 27, 2013 2:51:37 PM
> > Subject: Re: [vdsm] addNetwork to use existing nic conf
> >
> > On Wed, Nov 27, 2013 at 07:28:23AM -0500, Antoni Segura Puimedon wrote:
> > >
> > >
> > > ----- Original Message -----
> > > > From: "Dan Kenigsberg" <danken(a)redhat.com>
> > > > To: "Antoni Segura Puimedon" <asegurap(a)redhat.com>
> > > > Cc: "Yedidyah Bar David" <didi(a)redhat.com>,
"vdsm-devel"
> > > > <vdsm-devel(a)fedorahosted.org>
> > > > Sent: Wednesday, November 27, 2013 1:22:47 PM
> > > > Subject: Re: [vdsm] addNetwork to use existing nic conf
> > > >
> > > > On Wed, Nov 27, 2013 at 06:55:26AM -0500, Antoni Segura Puimedon
> > > > wrote:
> > > > >
> > > > >
> > > > > ----- Original Message -----
> > > > > > From: "Yedidyah Bar David"
<didi(a)redhat.com>
> > > > > > To: "Antoni Segura Puimedon"
<asegurap(a)redhat.com>
> > > > > > Cc: "vdsm-devel"
<vdsm-devel(a)fedorahosted.org>, "Alon Bar-Lev"
> > > > > > <alonbl(a)redhat.com>, "Sandro Bonazzola"
> > > > > > <sbonazzo(a)redhat.com>
> > > > > > Sent: Wednesday, November 27, 2013 11:18:39 AM
> > > > > > Subject: Re: addNetwork to use existing nic conf
> > > > > >
> > > > > > ----- Original Message -----
> > > > > > > From: "Antoni Segura Puimedon"
<asegurap(a)redhat.com>
> > > > > > > To: "Yedidyah Bar David"
<didi(a)redhat.com>
> > > > > > > Cc: "vdsm-devel"
<vdsm-devel(a)fedorahosted.org>, "Alon Bar-Lev"
> > > > > > > <alonbl(a)redhat.com>, "Sandro
Bonazzola"
> > > > > > > <sbonazzo(a)redhat.com>
> > > > > > > Sent: Wednesday, November 27, 2013 11:52:51 AM
> > > > > > > Subject: Re: addNetwork to use existing nic conf
> > > > > > >
> > > > > > >
> > > > > > >
> > > > > > > ----- Original Message -----
> > > > > > > > From: "Yedidyah Bar David"
<didi(a)redhat.com>
> > > > > > > > To: "vdsm-devel"
<vdsm-devel(a)fedorahosted.org>
> > > > > > > > Cc: "Alon Bar-Lev"
<alonbl(a)redhat.com>, "Sandro Bonazzola"
> > > > > > > > <sbonazzo(a)redhat.com>, "Antoni Segura
Puimedon"
> > > > > > > > <asegurap(a)redhat.com>
> > > > > > > > Sent: Wednesday, November 27, 2013 10:38:54 AM
> > > > > > > > Subject: addNetwork to use existing nic conf
> > > > > > > >
> > > > > > > > Hi all,
> > > > > > > >
> > > > > > > > While looking at [1], and reading the source of
bridge.py of
> > > > > > > > ovirt-hosted-engine-setup
> > > > > > > > and of ovirt-host-deploy, I think the correct
thing will be
> > > > > > > > for
> > > > > > > > addNetwork
> > > > > > > > to
> > > > > > > > not
> > > > > > > > require either bootproto=dhcp or
ipaddr/netmask/etc., but to
> > > > > > > > take
> > > > > > > > this
> > > > > > > > from
> > > > > > > > the existing
> > > > > > > > conf of the nics to be put inside the bridge.
> > > > > > >
> > > > > > > You mean the addNetwork in
vdsm/vdsm/configNetwork.py?
> > > > > >
> > > > > > We currently use vdsClient - 'vdsClient
addNetwork'.
> > > > > >
> > > > > > > If that is the case I would very much prefer not to
make such
> > > > > > > change,
> > > > > > > since
> > > > > > > that
> > > > > > > would make addNetwork even farther from referential
> > > > > > > transparency.
> > > > > > >
> > > > > > > What I propose is that the calling code will use the
new
> > > > > > > getBootProto
> > > > > > > introduced in:
> > > > > > > http://gerrit.ovirt.org/18484 (already merged).
> > > > > >
> > > > > > Does vdsClient support that?
> > > > >
> > > > > Well, vdsClient getVdsCaps returns the cfg information for all
the
> > > > > devices,
> > > > > part of that will be the bootproto if it is defined on the
ifcfg
> > > > > file
> > > > > of
> > > > > the
> > > > > device.
> > > >
> > > > We'd very much like to drop the 'cfg' element reported
per nic (it
> > > > breaks Vdsm's "network" abrstraction and would be
anoying to maintain
> > > > with iproute2 when we move to it. "BOOTPROTO" is there, and
would
> > > > have
> > > > to stay there (for backward compatibility with Engine), but please
> > > > avoid
> > > > using any other data.
> > >
> > > Well, for installation time, there must be something (not necessarily
> > > part
> > > of
> > > vdsm proper that is able to get the ip configuration of the device we
> > > connect
> > > through.
> > >
> > > Since it could be ifcfg info (el6), NM (newer distros),
> > > /etc/network/interfaces
> > > (debian derived) I would really make a separate solution to vdsm.
> >
> > No doubt about that:
> > Bug 987813 - [RFE] report BOOTPROTO and BONDING_OPTS independent of
> > netdevice.cfg
> >
>
> Sorry, I did not understand. Should I or should I not rely on getVdsCaps
> to get the ipaddr/netmask/gateway/whatever? Just getting bootproto from it
> does not help much if I have to read ifcfg files anyway.
getVdsCaps as it stands now is only working on el6 and Fedora for getting the
bootProto in the cfg field.
I understand that, but IIUC Dan said that this is going to be deprecated and
should not be relied upon. Since I need it for hosted-engine, which is also
supported only on el6 and fedora, that's not an issue. For now, anyway.
--
Didi
9:04 a.m.
On Wed, Nov 27, 2013 at 09:54:06AM -0500, Antoni Segura Puimedon wrote:
----- Original Message -----
> From: "Yedidyah Bar David" <didi(a)redhat.com>
> To: "Dan Kenigsberg" <danken(a)redhat.com>
> Cc: "Antoni Segura Puimedon" <asegurap(a)redhat.com>,
"vdsm-devel" <vdsm-devel(a)fedorahosted.org>
> Sent: Wednesday, November 27, 2013 3:47:20 PM
> Subject: Re: [vdsm] addNetwork to use existing nic conf
>
> ----- Original Message -----
> > From: "Dan Kenigsberg" <danken(a)redhat.com>
> > To: "Antoni Segura Puimedon" <asegurap(a)redhat.com>
> > Cc: "Yedidyah Bar David" <didi(a)redhat.com>,
"vdsm-devel"
> > <vdsm-devel(a)fedorahosted.org>
> > Sent: Wednesday, November 27, 2013 2:51:37 PM
> > Subject: Re: [vdsm] addNetwork to use existing nic conf
> >
> > On Wed, Nov 27, 2013 at 07:28:23AM -0500, Antoni Segura Puimedon wrote:
> > >
> > >
> > > ----- Original Message -----
> > > > From: "Dan Kenigsberg" <danken(a)redhat.com>
> > > > To: "Antoni Segura Puimedon" <asegurap(a)redhat.com>
> > > > Cc: "Yedidyah Bar David" <didi(a)redhat.com>,
"vdsm-devel"
> > > > <vdsm-devel(a)fedorahosted.org>
> > > > Sent: Wednesday, November 27, 2013 1:22:47 PM
> > > > Subject: Re: [vdsm] addNetwork to use existing nic conf
> > > >
> > > > On Wed, Nov 27, 2013 at 06:55:26AM -0500, Antoni Segura Puimedon
wrote:
> > > > >
> > > > >
> > > > > ----- Original Message -----
> > > > > > From: "Yedidyah Bar David"
<didi(a)redhat.com>
> > > > > > To: "Antoni Segura Puimedon"
<asegurap(a)redhat.com>
> > > > > > Cc: "vdsm-devel"
<vdsm-devel(a)fedorahosted.org>, "Alon Bar-Lev"
> > > > > > <alonbl(a)redhat.com>, "Sandro Bonazzola"
> > > > > > <sbonazzo(a)redhat.com>
> > > > > > Sent: Wednesday, November 27, 2013 11:18:39 AM
> > > > > > Subject: Re: addNetwork to use existing nic conf
> > > > > >
> > > > > > ----- Original Message -----
> > > > > > > From: "Antoni Segura Puimedon"
<asegurap(a)redhat.com>
> > > > > > > To: "Yedidyah Bar David"
<didi(a)redhat.com>
> > > > > > > Cc: "vdsm-devel"
<vdsm-devel(a)fedorahosted.org>, "Alon Bar-Lev"
> > > > > > > <alonbl(a)redhat.com>, "Sandro
Bonazzola"
> > > > > > > <sbonazzo(a)redhat.com>
> > > > > > > Sent: Wednesday, November 27, 2013 11:52:51 AM
> > > > > > > Subject: Re: addNetwork to use existing nic conf
> > > > > > >
> > > > > > >
> > > > > > >
> > > > > > > ----- Original Message -----
> > > > > > > > From: "Yedidyah Bar David"
<didi(a)redhat.com>
> > > > > > > > To: "vdsm-devel"
<vdsm-devel(a)fedorahosted.org>
> > > > > > > > Cc: "Alon Bar-Lev"
<alonbl(a)redhat.com>, "Sandro Bonazzola"
> > > > > > > > <sbonazzo(a)redhat.com>, "Antoni Segura
Puimedon"
> > > > > > > > <asegurap(a)redhat.com>
> > > > > > > > Sent: Wednesday, November 27, 2013 10:38:54 AM
> > > > > > > > Subject: addNetwork to use existing nic conf
> > > > > > > >
> > > > > > > > Hi all,
> > > > > > > >
> > > > > > > > While looking at [1], and reading the source of
bridge.py of
> > > > > > > > ovirt-hosted-engine-setup
> > > > > > > > and of ovirt-host-deploy, I think the correct
thing will be for
> > > > > > > > addNetwork
> > > > > > > > to
> > > > > > > > not
> > > > > > > > require either bootproto=dhcp or
ipaddr/netmask/etc., but to
> > > > > > > > take
> > > > > > > > this
> > > > > > > > from
> > > > > > > > the existing
> > > > > > > > conf of the nics to be put inside the bridge.
> > > > > > >
> > > > > > > You mean the addNetwork in
vdsm/vdsm/configNetwork.py?
> > > > > >
> > > > > > We currently use vdsClient - 'vdsClient
addNetwork'.
> > > > > >
> > > > > > > If that is the case I would very much prefer not to
make such
> > > > > > > change,
> > > > > > > since
> > > > > > > that
> > > > > > > would make addNetwork even farther from referential
transparency.
> > > > > > >
> > > > > > > What I propose is that the calling code will use the
new
> > > > > > > getBootProto
> > > > > > > introduced in:
> > > > > > > http://gerrit.ovirt.org/18484 (already merged).
> > > > > >
> > > > > > Does vdsClient support that?
> > > > >
> > > > > Well, vdsClient getVdsCaps returns the cfg information for all
the
> > > > > devices,
> > > > > part of that will be the bootproto if it is defined on the ifcfg
file
> > > > > of
> > > > > the
> > > > > device.
> > > >
> > > > We'd very much like to drop the 'cfg' element reported
per nic (it
> > > > breaks Vdsm's "network" abrstraction and would be
anoying to maintain
> > > > with iproute2 when we move to it. "BOOTPROTO" is there, and
would have
> > > > to stay there (for backward compatibility with Engine), but please
> > > > avoid
> > > > using any other data.
> > >
> > > Well, for installation time, there must be something (not necessarily
> > > part
> > > of
> > > vdsm proper that is able to get the ip configuration of the device we
> > > connect
> > > through.
> > >
> > > Since it could be ifcfg info (el6), NM (newer distros),
> > > /etc/network/interfaces
> > > (debian derived) I would really make a separate solution to vdsm.
> >
> > No doubt about that:
> > Bug 987813 - [RFE] report BOOTPROTO and BONDING_OPTS independent of
> > netdevice.cfg
> >
>
> Sorry, I did not understand. Should I or should I not rely on getVdsCaps
> to get the ipaddr/netmask/gateway/whatever? Just getting bootproto from it
> does not help much if I have to read ifcfg files anyway.
getVdsCaps as it stands now is only working on el6 and Fedora for getting the
bootProto in the cfg field.
...and for ipaddr/netmask/gateway it's the thing to use. Just note to
look for the lowercase values, not for the ones copied from the ifcfg.
Dan.
5:05 a.m.
On Wed, Nov 27, 2013 at 04:38:54AM -0500, Yedidyah Bar David wrote:
Hi all,
While looking at [1], and reading the source of bridge.py of ovirt-hosted-engine-setup
and of ovirt-host-deploy, I think the correct thing will be for addNetwork to not
require either bootproto=dhcp or ipaddr/netmask/etc., but to take this from the existing
conf of the nics to be put inside the bridge.
Does this make sense?
[1] https://bugzilla.redhat.com/show_bug.cgi?id=1013666
I do not think it does: addNetwork was designed to set up a network
accroding to a complete definition thereof. The current state and the
configuration of the underlying devices is intentionally overridden.
addNetwork's default for bootproto is not to set it in the ifcfg file
(which initscript translates to "none", i.e. static). Other users of
addNetwork may already rely on that, and forcing them to change is not
realistic (particularly given our willingness to deprecate
addNetwork/delNetwork/editNetwork in favor of setupNetworks).
The suggested logic is particularly fuzzy if we consider the fact that
addNetwork may set multiple ifcfg files. Which bootproto should it
select as a default if it is building a bond on top of 3 nics?
I assume that hosted-engine-setup has an argument for selecting the
management interface. I see no way around having it receive
--ipaddr/--netmask/--gateway/--bootproto too, or doing the guestwork
itself.
3838
days inactive
3838
days old
vdsm-devel@lists.fedorahosted.org
11 comments
3 participants
participants (3)
-
asegurap＠redhat.com -
Dan Kenigsberg -
didi＠redhat.com