Pretty printing for vdsClient

Hi fellow oVirters,

Working with the networking side of vdsm side, I've grown tired of the
looks of the output of vdsClient. Thus, I have submitted a patch:
    http://gerrit.ovirt.org/#/c/11979/
That pretty prints the dictionaries that are to be displayed, e.g.:
This http://pastebin.test.redhat.com/127370
Becomes http://pastebin.test.redhat.com/127373

Pavel Stehlik has suggested to make this change optional as a switch
to vdsClient (I guess I'd put -p|--pretty).

I would like some feedback and suggestions.

Best,

Toni

On 12/02/13 17:22, Antoni Segura Puimedon wrote:
>  Hi fellow oVirters,
>
>  Working with the networking side of vdsm side, I've grown tired of the
>  looks of the output of vdsClient. Thus, I have submitted a patch:
>       http://gerrit.ovirt.org/#/c/11979/
>  That pretty prints the dictionaries that are to be displayed, e.g.:
>  This http://pastebin.test.redhat.com/127370
>  Becomes http://pastebin.test.redhat.com/127373
>
>  Pavel Stehlik has suggested to make this change optional as a switch
>  to vdsClient (I guess I'd put -p|--pretty). 
Why not switch to it? What's the disadvantage? The single one I see is 
that perhaps it'll break the context of a 'grep' result.
Y.

>  I would like some feedback and suggestions.
>
>  Best,
>
>  Toni

Totally right both. I just sent another version of the patch
that makes it optional and contains an example in the commit
message.

http://gerrit.ovirt.org/#/c/11979/2/

----- Original Message -----
>  From: "Yaniv Kaul" <ykaul(a)redhat.com&gt;
>  To: "Antoni Segura Puimedon" <asegurap(a)redhat.com&gt;
>  Cc: "VDSM Project Development" <vdsm-devel(a)lists.fedorahosted.org&gt;,
> "Oded Ramraz" <oramraz(a)redhat.com&gt;, "Pavel
>  Stehlik" <pstehlik(a)redhat.com&gt;
>  Sent: Tuesday, February 12, 2013 4:57:48 PM
>  Subject: Re: Pretty printing for vdsClient
>  
>  On 12/02/13 17:22, Antoni Segura Puimedon wrote:
>  > Hi fellow oVirters,
>  >
>  > Working with the networking side of vdsm side, I've grown tired of
>  > the
>  > looks of the output of vdsClient. Thus, I have submitted a patch:
>  >      http://gerrit.ovirt.org/#/c/11979/
>  > That pretty prints the dictionaries that are to be displayed, e.g.:
>  > This http://pastebin.test.redhat.com/127370
>  > Becomes http://pastebin.test.redhat.com/127373
>  >
>  > Pavel Stehlik has suggested to make this change optional as a
>  > switch
>  > to vdsClient (I guess I'd put -p|--pretty).
>  
>  Why not switch to it? What's the disadvantage? The single one I see
>  is
>  that perhaps it'll break the context of a 'grep' result.
>  Y.
>  
>  >
>  > I would like some feedback and suggestions.
>  >
>  > Best,
>  >
>  > Toni
>  
>

[Dan Kenigsberg]

On Tue, Feb 12, 2013 at 05:57:48PM +0200, Yaniv Kaul wrote:
>  On 12/02/13 17:22, Antoni Segura Puimedon wrote:
>  >Hi fellow oVirters,
>  >
>  >Working with the networking side of vdsm side, I've grown tired of the
>  >looks of the output of vdsClient. Thus, I have submitted a patch:
>  >     http://gerrit.ovirt.org/#/c/11979/
>  >That pretty prints the dictionaries that are to be displayed, e.g.:
>  >This http://pastebin.test.redhat.com/127370
>  >Becomes http://pastebin.test.redhat.com/127373
>  >
>  >Pavel Stehlik has suggested to make this change optional as a switch
>  >to vdsClient (I guess I'd put -p|--pretty).
>  
>  Why not switch to it? What's the disadvantage? The single one I see
>  is that perhaps it'll break the context of a 'grep' result. 
Exactly - I had a vague memory of your team using vdsClient directly.
I'd like to warn potential users of this change.

On Tue, Feb 12, 2013 at 10:22:08AM -0500, Antoni Segura Puimedon wrote:
>  Working with the networking side of vdsm side, I've grown tired
> of the
>  looks of the output of vdsClient. Thus, I have submitted a patch:
>      http://gerrit.ovirt.org/#/c/11979/
>  That pretty prints the dictionaries that are to be displayed, e.g.:
>  This http://pastebin.test.redhat.com/127370
>  Becomes http://pastebin.test.redhat.com/127373 
That's a non-public pastebin. I wouldn't mind an example in the commit
message.

[Vinzenz Feenstra]

On 02/12/2013 04:22 PM, Antoni Segura Puimedon wrote:
>  Hi fellow oVirters,
>
>  Working with the networking side of vdsm side, I've grown tired of the
>  looks of the output of vdsClient. Thus, I have submitted a patch:
>       http://gerrit.ovirt.org/#/c/11979/
>  That pretty prints the dictionaries that are to be displayed, e.g.:
>  This http://pastebin.test.redhat.com/127370
>  Becomes http://pastebin.test.redhat.com/127373
>
>  Pavel Stehlik has suggested to make this change optional as a switch
>  to vdsClient (I guess I'd put -p|--pretty). 
+1 This should be optional or you
have even more lines you might not 
even care about.
>  I would like some feedback and suggestions.
>
>  Best,
>
>  Toni
>  
-- 
Regards,

Vinzenz Feenstra | Senior Software Engineer
RedHat Engineering Virtualization R & D
Phone: [phone]
IRC: vfeenstr or evilissimo

Better technology. Faster innovation. Powered by community collaboration.
See how it works at redhat.com