vdsm-patches November 2013

vdsm-patches@lists.fedorahosted.org

60 participants
580 discussions

Change in vdsm[master]: Fix log message
by sgotliv＠redhat.com 05 Nov '13

05 Nov '13

Sergey Gotliv has uploaded a new change for review. Change subject: Fix log message ...................................................................... Fix log message Previous message used "neither" which is not correct when the number of disks is not 2. Change-Id: I6e9ef4ca3af5d5f1d78c1b0c7d108412e00e64cb Signed-off-by: Sergey Gotliv <sgotliv(a)redhat.com> --- M vdsm/vm.py 1 file changed, 1 insertion(+), 1 deletion(-) git pull ssh://gerrit.ovirt.org:29418/vdsm refs/changes/25/20925/1 diff --git a/vdsm/vm.py b/vdsm/vm.py index f95a1d1..ad1bf5e 100644 --- a/vdsm/vm.py +++ b/vdsm/vm.py @@ -517,7 +517,7 @@ extend.append((drive, capacity, alloc, physical)) if not extend: - self._log.info('Neither of VM drives will be extended.') + self._log.info('No VM drives will be extended.') return for drive, capacity, alloc, physical in extend: -- To view, visit http://gerrit.ovirt.org/20925 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: newchange Gerrit-Change-Id: I6e9ef4ca3af5d5f1d78c1b0c7d108412e00e64cb Gerrit-PatchSet: 1 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Sergey Gotliv <sgotliv(a)redhat.com>

2 4

Change in vdsm[master]: vm: Pause vm in case volume allocation is greater than lv size
by ykaplan＠redhat.com 05 Nov '13

05 Nov '13

Yeela Kaplan has uploaded a new change for review. Change subject: vm: Pause vm in case volume allocation is greater than lv size ...................................................................... vm: Pause vm in case volume allocation is greater than lv size qemu bug is causing qcow to allocate extents beyond the volume's physical size. In this case we want to avoid extending the volume in infinite loop. Also, pause the vm, to avoid data corruption. Change-Id: Id95aa1ed7508218d8ae6a878606cd2d251ac2b05 Bug-Url: https://bugzilla.redhat.com/show_bug.cgi?id=998443 Signed-off-by: Yeela Kaplan <ykaplan(a)redhat.com> --- M vdsm/vm.py 1 file changed, 9 insertions(+), 2 deletions(-) git pull ssh://gerrit.ovirt.org:29418/vdsm refs/changes/19/19719/1 diff --git a/vdsm/vm.py b/vdsm/vm.py index 92d274e..baf407e 100644 --- a/vdsm/vm.py +++ b/vdsm/vm.py @@ -508,6 +508,12 @@ capacity, alloc, physical = \ self._vm._dom.blockInfo(vmDrive.path, 0) + if physical - alloc < 0: + self.pause(pauseCode='EOTHER') + self._log.error('vm: %s paused due to the corrupted volume: ', + self._vm.id, vmDrive.path) + continue + if physical - alloc >= vmDrive.watermarkLimit: continue @@ -2407,12 +2413,13 @@ if not guestCpuLocked: self._guestCpuLock.release() - def pause(self, afterState='Paused', guestCpuLocked=False): + def pause(self, afterState='Paused', guestCpuLocked=False, + pauseCode='NOERR'): if not guestCpuLocked: self._acquireCpuLockWithTimeout() try: with self._confLock: - self.conf['pauseCode'] = 'NOERR' + self.conf['pauseCode'] = pauseCode self._underlyingPause() if hasattr(self, 'updateGuestCpuRunning'): self.updateGuestCpuRunning() -- To view, visit http://gerrit.ovirt.org/19719 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: newchange Gerrit-Change-Id: Id95aa1ed7508218d8ae6a878606cd2d251ac2b05 Gerrit-PatchSet: 1 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Yeela Kaplan <ykaplan(a)redhat.com>

8 35

Change in vdsm[master]: tests: prevent hook validation decorator from leaving script...
by Jenkins CI RO 05 Nov '13

05 Nov '13

1 0

Change in vdsm[master]: tests: prevent hook validation decorator from leaving script...
by Dan Kenigsberg 05 Nov '13

05 Nov '13

Dan Kenigsberg has submitted this change and it was merged. Change subject: tests: prevent hook validation decorator from leaving scripts installed ...................................................................... tests: prevent hook validation decorator from leaving scripts installed It fixes a bug in the hook validation decorator, that left tests scripts installed into the system. Now they're properly removed right after the tests. Adds rmTree function to vdsm.utils. Change-Id: I138c3eab77ea6d35d6a997049940923026e06d96 Signed-off-by: Miguel Angel Ajo <miguelangel(a)ajo.es> Reviewed-on: http://gerrit.ovirt.org/20310 Reviewed-by: Dan Kenigsberg <danken(a)redhat.com> Tested-by: Dan Kenigsberg <danken(a)redhat.com> --- M lib/vdsm/utils.py M tests/hookValidation.py 2 files changed, 27 insertions(+), 5 deletions(-) Approvals: Dan Kenigsberg: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/20310 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I138c3eab77ea6d35d6a997049940923026e06d96 Gerrit-PatchSet: 11 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Miguel Angel Ajo Pelayo <miguelangel(a)ajo.es> Gerrit-Reviewer: Antoni Segura Puimedon <asegurap(a)redhat.com> Gerrit-Reviewer: Dan Kenigsberg <danken(a)redhat.com> Gerrit-Reviewer: Miguel Angel Ajo Pelayo <miguelangel(a)ajo.es> Gerrit-Reviewer: Nir Soffer <nsoffer(a)redhat.com> Gerrit-Reviewer: oVirt Jenkins CI Server

1 0

Change in vdsm[master]: tests: prevent hook validation decorator from leaving script...
by Dan Kenigsberg 05 Nov '13

05 Nov '13

Dan Kenigsberg has posted comments on this change. Change subject: tests: prevent hook validation decorator from leaving scripts installed ...................................................................... Patch Set 10: Verified+1 Code-Review+2 -- To view, visit http://gerrit.ovirt.org/20310 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I138c3eab77ea6d35d6a997049940923026e06d96 Gerrit-PatchSet: 10 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Miguel Angel Ajo Pelayo <miguelangel(a)ajo.es> Gerrit-Reviewer: Antoni Segura Puimedon <asegurap(a)redhat.com> Gerrit-Reviewer: Dan Kenigsberg <danken(a)redhat.com> Gerrit-Reviewer: Miguel Angel Ajo Pelayo <miguelangel(a)ajo.es> Gerrit-Reviewer: Nir Soffer <nsoffer(a)redhat.com> Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No

1 0

Change in vdsm[master]: tests: prevent hook validation decorator from leaving script...
by Dan Kenigsberg 05 Nov '13

05 Nov '13

Dan Kenigsberg has posted comments on this change. Change subject: tests: prevent hook validation decorator from leaving scripts installed ...................................................................... Patch Set 9: (1 comment) .................................................... File lib/vdsm/utils.py Line 124: If the directory doesn't exist is assumed that it was already removed. Line 125: """ Line 126: try: Line 127: shutil.rmtree(directoryToRemove) Line 128: except OSError as e: Thanks, but I find it important not to silently swallow exceptions. I'll add logging to the positive flow myself. Line 129: if e.errno != errno.ENOENT: Line 130: raise Line 131: Line 132: IPXMLRPCRequestHandler = SimpleXMLRPCRequestHandler -- To view, visit http://gerrit.ovirt.org/20310 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I138c3eab77ea6d35d6a997049940923026e06d96 Gerrit-PatchSet: 9 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Miguel Angel Ajo Pelayo <miguelangel(a)ajo.es> Gerrit-Reviewer: Antoni Segura Puimedon <asegurap(a)redhat.com> Gerrit-Reviewer: Dan Kenigsberg <danken(a)redhat.com> Gerrit-Reviewer: Miguel Angel Ajo Pelayo <miguelangel(a)ajo.es> Gerrit-Reviewer: Nir Soffer <nsoffer(a)redhat.com> Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: Yes

1 0

Change in vdsm[master]: xmlrpc: Parsing error logging enhancement - vdsClient
by Dan Kenigsberg 05 Nov '13

05 Nov '13

Dan Kenigsberg has posted comments on this change. Change subject: xmlrpc: Parsing error logging enhancement - vdsClient ...................................................................... Patch Set 4: (1 comment) .................................................... File lib/vdsm/vdscli.py.in Line 40: Line 41: def __getattr__(self, name): Line 42: if hasattr(self._transport, name): Line 43: func = getattr(self._transport, name) Line 44: if name == 'parse_response': And guess what: the language as a built-in mechanism to wrap a single method. It's called inheritance, and it's almost perfect for the job. (Why "almost"? since we need to define the class on function run time). If you hate that sooo much, have __init__ set self.parse_response = self._wrapped_parse_response Line 45: return lambda *args, **kwargs: self._wrap(name, Line 46: func, args, kwargs) Line 47: else: Line 48: return func -- To view, visit http://gerrit.ovirt.org/20627 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ife29c4f7749b9cd8a4ad892f486d91509e505ae4 Gerrit-PatchSet: 4 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Piotr Kliczewski <piotr.kliczewski(a)gmail.com> Gerrit-Reviewer: Dan Kenigsberg <danken(a)redhat.com> Gerrit-Reviewer: Piotr Kliczewski <piotr.kliczewski(a)gmail.com> Gerrit-Reviewer: Saggi Mizrahi <smizrahi(a)redhat.com> Gerrit-Reviewer: Yaniv Bronhaim <ybronhei(a)redhat.com> Gerrit-Reviewer: mooli tayer <mtayer(a)redhat.com> Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: Yes

1 0

Change in vdsm[master]: tests: prevent hook validation decorator from leaving script...
by Jenkins CI RO 05 Nov '13

05 Nov '13

oVirt Jenkins CI Server has posted comments on this change. Change subject: tests: prevent hook validation decorator from leaving scripts installed ...................................................................... Patch Set 9: No Builds Executed http://jenkins.ovirt.org/job/vdsm_unit_tests_gerrit_el/4423/ : To avoid overloading the infrastructure, a whitelist for running gerrit triggered jobs has been set in place, if you feel like you should be in it, please contact infra at ovirt dot org. http://jenkins.ovirt.org/job/vdsm_pep8_gerrit/5227/ : To avoid overloading the infrastructure, a whitelist for running gerrit triggered jobs has been set in place, if you feel like you should be in it, please contact infra at ovirt dot org. http://jenkins.ovirt.org/job/vdsm_unit_tests_gerrit/5303/ : To avoid overloading the infrastructure, a whitelist for running gerrit triggered jobs has been set in place, if you feel like you should be in it, please contact infra at ovirt dot org. -- To view, visit http://gerrit.ovirt.org/20310 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I138c3eab77ea6d35d6a997049940923026e06d96 Gerrit-PatchSet: 9 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Miguel Angel Ajo Pelayo <miguelangel(a)ajo.es> Gerrit-Reviewer: Antoni Segura Puimedon <asegurap(a)redhat.com> Gerrit-Reviewer: Dan Kenigsberg <danken(a)redhat.com> Gerrit-Reviewer: Miguel Angel Ajo Pelayo <miguelangel(a)ajo.es> Gerrit-Reviewer: Nir Soffer <nsoffer(a)redhat.com> Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No

1 0

Change in vdsm[master]: tests: prevent hook validation decorator from leaving script...
by Jenkins CI RO 05 Nov '13

05 Nov '13

oVirt Jenkins CI Server has posted comments on this change. Change subject: tests: prevent hook validation decorator from leaving scripts installed ...................................................................... Patch Set 8: No Builds Executed http://jenkins.ovirt.org/job/vdsm_unit_tests_gerrit_el/4422/ : To avoid overloading the infrastructure, a whitelist for running gerrit triggered jobs has been set in place, if you feel like you should be in it, please contact infra at ovirt dot org. http://jenkins.ovirt.org/job/vdsm_pep8_gerrit/5226/ : To avoid overloading the infrastructure, a whitelist for running gerrit triggered jobs has been set in place, if you feel like you should be in it, please contact infra at ovirt dot org. http://jenkins.ovirt.org/job/vdsm_unit_tests_gerrit/5302/ : To avoid overloading the infrastructure, a whitelist for running gerrit triggered jobs has been set in place, if you feel like you should be in it, please contact infra at ovirt dot org. -- To view, visit http://gerrit.ovirt.org/20310 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I138c3eab77ea6d35d6a997049940923026e06d96 Gerrit-PatchSet: 8 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Miguel Angel Ajo Pelayo <miguelangel(a)ajo.es> Gerrit-Reviewer: Antoni Segura Puimedon <asegurap(a)redhat.com> Gerrit-Reviewer: Dan Kenigsberg <danken(a)redhat.com> Gerrit-Reviewer: Miguel Angel Ajo Pelayo <miguelangel(a)ajo.es> Gerrit-Reviewer: Nir Soffer <nsoffer(a)redhat.com> Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No

1 0

Change in vdsm[ovirt-3.3]: Don't fail hotplugNic operation when after hook fails
by ybronhei＠redhat.com 05 Nov '13

05 Nov '13

Hello Antoni Segura Puimedon, Dan Kenigsberg, I'd like you to do a code review. Please visit http://gerrit.ovirt.org/20901 to review the following change. Change subject: Don't fail hotplugNic operation when after hook fails ...................................................................... Don't fail hotplugNic operation when after hook fails Change-Id: I8df7812cee7632addf87f7dc1c49182f55c51e8e Bug-Url: https://bugzilla.redhat.com/show_bug.cgi?id=1015171 Signed-off-by: Yaniv Bronhaim <ybronhei(a)redhat.com> Reviewed-on: http://gerrit.ovirt.org/20876 Reviewed-by: Antoni Segura Puimedon <asegurap(a)redhat.com> Reviewed-by: Dan Kenigsberg <danken(a)redhat.com> --- M vdsm/hooks.py 1 file changed, 1 insertion(+), 1 deletion(-) git pull ssh://gerrit.ovirt.org:29418/vdsm refs/changes/01/20901/1 diff --git a/vdsm/hooks.py b/vdsm/hooks.py index 492f937..a1f8158 100644 --- a/vdsm/hooks.py +++ b/vdsm/hooks.py @@ -251,7 +251,7 @@ def after_nic_hotplug(nicxml, vmconf={}, params={}): return _runHooksDir(nicxml, 'after_nic_hotplug', vmconf=vmconf, - params=params) + params=params, raiseError=False) def before_nic_hotunplug(nicxml, vmconf={}, params={}): -- To view, visit http://gerrit.ovirt.org/20901 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: newchange Gerrit-Change-Id: I8df7812cee7632addf87f7dc1c49182f55c51e8e Gerrit-PatchSet: 1 Gerrit-Project: vdsm Gerrit-Branch: ovirt-3.3 Gerrit-Owner: Yaniv Bronhaim <ybronhei(a)redhat.com> Gerrit-Reviewer: Antoni Segura Puimedon <asegurap(a)redhat.com> Gerrit-Reviewer: Dan Kenigsberg <danken(a)redhat.com>

2 4

← Newer
1
...
51
52
53
54
55
56
57
58
Older →

Jump to page:

2024

2023

2022

2021

2020

2019

2018

2017

2016

2015

2014

2013

2012

2011

vdsm-patches November 2013