vdsm-patches November 2015

vdsm-patches@lists.fedorahosted.org

47 participants
406 discussions

Change in vdsm[master]: virt: Correct VM state before vm.cont() in _recover()
by smelamud＠redhat.com 16 Jun '16

16 Jun '16

Shmuel Leib Melamud has uploaded a new change for review. Change subject: virt: Correct VM state before vm.cont() in _recover() ...................................................................... virt: Correct VM state before vm.cont() in _recover() In SourceThread._recover(), if error occured while hibernating a VM, set VM status to PAUSED before calling vm.cont(). Otherwise, vm.cont() will fail to run in SAVING_STATE state and the VM will be left paused. Change-Id: I5b1c7b4eecacf87ece48dc563fd2da294af0510b Bug-Url: https://bugzilla.redhat.com/show_bug.cgi?id=1238536 Signed-off-by: Shmuel Melamud <smelamud(a)redhat.com> --- M vdsm/virt/migration.py 1 file changed, 1 insertion(+), 0 deletions(-) git pull ssh://gerrit.ovirt.org:29418/vdsm refs/changes/27/47527/1 diff --git a/vdsm/virt/migration.py b/vdsm/virt/migration.py index 32caccb..f950a6f 100644 --- a/vdsm/virt/migration.py +++ b/vdsm/virt/migration.py @@ -213,6 +213,7 @@ self.log.exception("Failed to destroy remote VM") # if the guest was stopped before migration, we need to cont it if self.hibernating: + self._vm.lastStatus = vmstatus.PAUSED self._vm.cont() # either way, migration has finished self._vm.lastStatus = vmstatus.UP -- To view, visit https://gerrit.ovirt.org/47527 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: newchange Gerrit-Change-Id: I5b1c7b4eecacf87ece48dc563fd2da294af0510b Gerrit-PatchSet: 1 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Shmuel Leib Melamud <smelamud(a)redhat.com>

4 9

Change in vdsm[ovirt-3.6]: netinfo: rework reporting of DHCPv4/6 on network devices
by osvoboda＠redhat.com 16 Nov '15

16 Nov '15

Hello Ido Barkan, Dan Kenigsberg, I'd like you to do a code review. Please visit https://gerrit.ovirt.org/48513 to review the following change. Change subject: netinfo: rework reporting of DHCPv4/6 on network devices ...................................................................... netinfo: rework reporting of DHCPv4/6 on network devices This patch addresses the same problem [1] as commit b92edb but hopefully in a more readable, verbose way. [1] DHCP still being reported for hours after a network got static IP configuration, because reporting is based on dhclient's leases. Change-Id: Iaffdc836f8f64ecdc0a7e37ef50c228032f99696 Bug-Url: https://bugzilla.redhat.com/1184497 Signed-off-by: Ondřej Svoboda <osvoboda(a)redhat.com> Reviewed-on: https://gerrit.ovirt.org/46430 Continuous-Integration: Jenkins CI Reviewed-by: Ido Barkan <ibarkan(a)redhat.com> Reviewed-by: Dan Kenigsberg <danken(a)redhat.com> --- M lib/vdsm/netinfo.py 1 file changed, 49 insertions(+), 22 deletions(-) git pull ssh://gerrit.ovirt.org:29418/vdsm refs/changes/13/48513/1 diff --git a/lib/vdsm/netinfo.py b/lib/vdsm/netinfo.py index 227b435..f1932ee 100644 --- a/lib/vdsm/netinfo.py +++ b/lib/vdsm/netinfo.py @@ -442,10 +442,6 @@ else: try: if family == 4: - # Read dhcpv4 from an associated network's reported information - if 'dhcpv4' in net_attrs: - return net_attrs['dhcpv4'] - # Read the same information from RunningConfig return net_attrs['bootproto'] == 'dhcp' else: return net_attrs['dhcpv6'] @@ -490,14 +486,6 @@ return data -def _netinfo_by_device(networks): - netinfo_by_device = {} - for net_attrs in networks.itervalues(): - device = net_attrs['iface'] - netinfo_by_device[device] = net_attrs - return netinfo_by_device - - def _bridgeinfo(link): return {'ports': ports(link.name), 'stp': bridge_stp_state(link.name), @@ -536,7 +524,7 @@ return {'iface': link.device, 'vlanid': link.vlanid} -def _devinfo(link, routes, ipaddrs, dhcpv4_ifaces, dhcpv6_ifaces, net_attrs): +def _devinfo(link, routes, ipaddrs, dhcpv4_ifaces, dhcpv6_ifaces): ipv4addr, ipv4netmask, ipv4addrs, ipv6addrs = getIpInfo(link.name, ipaddrs) info = {'addr': ipv4addr, 'cfg': getIfaceCfg(link.name), @@ -544,14 +532,54 @@ 'ipv6addrs': ipv6addrs, 'gateway': _get_gateway(routes, link.name), 'ipv6gateway': _get_gateway(routes, link.name, family=6), - 'dhcpv4': _dhcp_used(link.name, dhcpv4_ifaces, net_attrs), - 'dhcpv6': _dhcp_used(link.name, dhcpv6_ifaces, net_attrs, - family=6), + 'dhcpv4': link.name in dhcpv4_ifaces, # to be refined if a network + 'dhcpv6': link.name in dhcpv6_ifaces, # is not configured for DHCP 'mtu': str(link.mtu), 'netmask': ipv4netmask} if 'BOOTPROTO' not in info['cfg']: info['cfg']['BOOTPROTO'] = 'dhcp' if info['dhcpv4'] else 'none' return info + + +def _propose_updates_to_reported_dhcp(network_info, networking): + """ + Report DHCPv4/6 of a network's topmost device based on the network's + configuration, to fix bug #1184497 (DHCP still being reported for hours + after a network got static IP configuration, as reporting is based on + dhclient leases). + """ + updated_networking = dict(bondings={}, bridges={}, nics={}, vlans={}) + network_device = network_info['iface'] + + for devices in ('bridges', 'vlans', 'bondings', 'nics'): + dev_info = networking[devices].get(network_device) + if dev_info: + cfg = {} + updated_networking[devices][network_device] = { + 'dhcpv4': network_info['dhcpv4'], + 'dhcpv6': network_info['dhcpv6'], + 'cfg': cfg, + } + cfg['BOOTPROTO'] = 'dhcp' if network_info['dhcpv4'] else 'none' + break + + return updated_networking + + +def _update_reported_dhcp(replacement, networking): + """ + For each network device (representing a network), apply updates to reported + DHCP-related fields, as prepared by _propose_updates_to_reported_dhcp. + """ + for device_type, devices in replacement.iteritems(): + for device_name, replacement_device_info in devices.iteritems(): + device_info = networking[device_type][device_name] + device_info['dhcpv4'] = replacement_device_info['dhcpv4'] + device_info['dhcpv6'] = replacement_device_info['dhcpv6'] + # Remove when cluster level < 3.6 is no longer supported and thus + # it is not necessary to report ifcfg-like BOOTPROTO field. + if replacement_device_info['cfg']: + device_info['cfg'].update(replacement_device_info['cfg']) def _parse_expiry_time(expiry_time): @@ -742,8 +770,6 @@ else: networking['networks'] = vdsmnets - netinfo_by_device = _netinfo_by_device(networking['networks']) - for dev in (link for link in getLinks() if not link.isHidden()): if dev.isBRIDGE(): devinfo = networking['bridges'][dev.name] = _bridgeinfo(dev) @@ -756,15 +782,16 @@ else: continue devinfo.update(_devinfo(dev, routes, ipaddrs, dhcpv4_ifaces, - dhcpv6_ifaces, - netinfo_by_device.get(dev.name, None))) + dhcpv6_ifaces)) if dev.isBOND(): _bondOptsCompat(devinfo) _bondCustomOpts(dev, devinfo, running_config) - for network, network_info in networking['networks'].iteritems(): + for network_name, network_info in networking['networks'].iteritems(): if network_info['bridged']: - network_info['cfg'] = networking['bridges'][network]['cfg'] + network_info['cfg'] = networking['bridges'][network_name]['cfg'] + updates = _propose_updates_to_reported_dhcp(network_info, networking) + _update_reported_dhcp(updates, networking) return networking -- To view, visit https://gerrit.ovirt.org/48513 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: newchange Gerrit-Change-Id: Iaffdc836f8f64ecdc0a7e37ef50c228032f99696 Gerrit-PatchSet: 1 Gerrit-Project: vdsm Gerrit-Branch: ovirt-3.6 Gerrit-Owner: Ondřej Svoboda <osvoboda(a)redhat.com> Gerrit-Reviewer: Dan Kenigsberg <danken(a)redhat.com> Gerrit-Reviewer: Ido Barkan <ibarkan(a)redhat.com>

4 6

Change in vdsm[ovirt-3.6]: netinfo: rename variables in get()
by osvoboda＠redhat.com 16 Nov '15

16 Nov '15

Hello Ido Barkan, Dan Kenigsberg, I'd like you to do a code review. Please visit https://gerrit.ovirt.org/48511 to review the following change. Change subject: netinfo: rename variables in get() ...................................................................... netinfo: rename variables in get() Change-Id: I3bcf1780c97e15b12543293db69addd96d0ac586 Signed-off-by: Ondřej Svoboda <osvoboda(a)redhat.com> Reviewed-on: https://gerrit.ovirt.org/46874 Continuous-Integration: Jenkins CI Reviewed-by: Ido Barkan <ibarkan(a)redhat.com> Reviewed-by: Dan Kenigsberg <danken(a)redhat.com> --- M lib/vdsm/netinfo.py 1 file changed, 15 insertions(+), 14 deletions(-) git pull ssh://gerrit.ovirt.org:29418/vdsm refs/changes/11/48511/1 diff --git a/lib/vdsm/netinfo.py b/lib/vdsm/netinfo.py index cf0c7a3..227b435 100644 --- a/lib/vdsm/netinfo.py +++ b/lib/vdsm/netinfo.py @@ -726,8 +726,8 @@ def get(vdsmnets=None): - d = {'bondings': {}, 'bridges': {}, 'networks': {}, 'nics': {}, - 'vlans': {}} + networking = {'bondings': {}, 'bridges': {}, 'networks': {}, 'nics': {}, + 'vlans': {}} paddr = permAddr() ipaddrs = _getIpAddrs() dhcpv4_ifaces, dhcpv6_ifaces = _get_dhclient_ifaces() @@ -736,22 +736,23 @@ if vdsmnets is None: libvirt_nets = networks() - d['networks'] = libvirtNets2vdsm(libvirt_nets, routes, ipaddrs, - dhcpv4_ifaces, dhcpv6_ifaces) + networking['networks'] = libvirtNets2vdsm(libvirt_nets, routes, + ipaddrs, + dhcpv4_ifaces, dhcpv6_ifaces) else: - d['networks'] = vdsmnets + networking['networks'] = vdsmnets - netinfo_by_device = _netinfo_by_device(d['networks']) + netinfo_by_device = _netinfo_by_device(networking['networks']) for dev in (link for link in getLinks() if not link.isHidden()): if dev.isBRIDGE(): - devinfo = d['bridges'][dev.name] = _bridgeinfo(dev) + devinfo = networking['bridges'][dev.name] = _bridgeinfo(dev) elif dev.isNICLike(): - devinfo = d['nics'][dev.name] = _nicinfo(dev, paddr) + devinfo = networking['nics'][dev.name] = _nicinfo(dev, paddr) elif dev.isBOND(): - devinfo = d['bondings'][dev.name] = _bondinfo(dev) + devinfo = networking['bondings'][dev.name] = _bondinfo(dev) elif dev.isVLAN(): - devinfo = d['vlans'][dev.name] = _vlaninfo(dev) + devinfo = networking['vlans'][dev.name] = _vlaninfo(dev) else: continue devinfo.update(_devinfo(dev, routes, ipaddrs, dhcpv4_ifaces, @@ -761,11 +762,11 @@ _bondOptsCompat(devinfo) _bondCustomOpts(dev, devinfo, running_config) - for net, attrs in d['networks'].iteritems(): - if attrs['bridged']: - attrs['cfg'] = d['bridges'][net]['cfg'] + for network, network_info in networking['networks'].iteritems(): + if network_info['bridged']: + network_info['cfg'] = networking['bridges'][network]['cfg'] - return d + return networking def isVlanned(dev): -- To view, visit https://gerrit.ovirt.org/48511 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: newchange Gerrit-Change-Id: I3bcf1780c97e15b12543293db69addd96d0ac586 Gerrit-PatchSet: 1 Gerrit-Project: vdsm Gerrit-Branch: ovirt-3.6 Gerrit-Owner: Ondřej Svoboda <osvoboda(a)redhat.com> Gerrit-Reviewer: Dan Kenigsberg <danken(a)redhat.com> Gerrit-Reviewer: Ido Barkan <ibarkan(a)redhat.com>

4 7

Change in vdsm[master]: jsonrpcvdscli: make sure not to ignore response queue
by Piotr Kliczewski 16 Nov '15

16 Nov '15

Piotr Kliczewski has uploaded a new change for review. Change subject: jsonrpcvdscli: make sure not to ignore response queue ...................................................................... jsonrpcvdscli: make sure not to ignore response queue In jsonrpcvdscli we provide responseQueue but we ignore it and we generate new queue name by using uuid4(). This patch makes sure not to ignore provided responseQueue. Change-Id: I4d6991b22f36b1a62e167a6be5c7229479f895df Signed-off-by: pkliczewski <piotr.kliczewski(a)gmail.com> --- M lib/vdsm/jsonrpcvdscli.py 1 file changed, 4 insertions(+), 1 deletion(-) git pull ssh://gerrit.ovirt.org:29418/vdsm refs/changes/09/48609/1 diff --git a/lib/vdsm/jsonrpcvdscli.py b/lib/vdsm/jsonrpcvdscli.py index 280d26f..c9a8b4d 100644 --- a/lib/vdsm/jsonrpcvdscli.py +++ b/lib/vdsm/jsonrpcvdscli.py @@ -147,8 +147,11 @@ else: sslctx = None + if responseQueue is None: + responseQueue = str(uuid4()) + return stompreactor.StandAloneRpcClient( - host, port, requestQueue, str(uuid4()), sslctx, + host, port, requestQueue, responseQueue, sslctx, lazy_start=False) -- To view, visit https://gerrit.ovirt.org/48609 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: newchange Gerrit-Change-Id: I4d6991b22f36b1a62e167a6be5c7229479f895df Gerrit-PatchSet: 1 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Piotr Kliczewski <piotr.kliczewski(a)gmail.com>

2 2

Change in vdsm[master]: stomp: slow data read when connected from localhost
by Piotr Kliczewski 16 Nov '15

16 Nov '15

Piotr Kliczewski has uploaded a new change for review. Change subject: stomp: slow data read when connected from localhost ...................................................................... stomp: slow data read when connected from localhost When jsonrpcvdscli is used to connect to vdsm from localhost there was an issue with receiving data. Local connection use loopback interface which do not split data into packets but delivers it as is. >From asyncore perspective this delivery generates single read event. When connection is remote there is event generated per packet. When we receive bigger data than our buffer size and the connection is local we read only amount which fits into our buffer (4096) and wait for next event which never arrives. The code wakes up when there is an attempt to send/receive heartbeat (every 5 seconds). This behavior delays reading response from calls like getVdsCaps for around 5 seconds. We solved this issue by checking whether stomp frame was parsed from data read and if the size of this data equals to buffer size and connection is local we attempt to read again. Change-Id: I279b2cde25ed9bb42954cf8f72673bd0aad0a6a5 Signed-off-by: pkliczewski <piotr.kliczewski(a)gmail.com> --- M lib/yajsonrpc/stomp.py 1 file changed, 18 insertions(+), 5 deletions(-) git pull ssh://gerrit.ovirt.org:29418/vdsm refs/changes/08/48608/1 diff --git a/lib/yajsonrpc/stomp.py b/lib/yajsonrpc/stomp.py index e480578..e37becf 100644 --- a/lib/yajsonrpc/stomp.py +++ b/lib/yajsonrpc/stomp.py @@ -348,19 +348,32 @@ self._frame_handler.handle_connect(self) def handle_read(self, dispatcher): + parser = self._parser + try: + size = self.read_data(dispatcher, parser) + + if (parser.pending == 0 and + size == self._bufferSize and + dispatcher.socket.getpeername()[0] == '127.0.0.1'): + self.handle_read(dispatcher) + except socket.error: + dispatcher.handle_error() + return + + while parser.pending > 0: + self._frame_handler.handle_frame(self, parser.popFrame()) + + def read_data(self, dispatcher, parser): try: data = dispatcher.recv(self._bufferSize) except socket.error: dispatcher.handle_error() return - parser = self._parser - if data is not None: parser.parse(data) - - while parser.pending > 0: - self._frame_handler.handle_frame(self, parser.popFrame()) + return len(data) + return None def popFrame(self): return self._parser.popFrame() -- To view, visit https://gerrit.ovirt.org/48608 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: newchange Gerrit-Change-Id: I279b2cde25ed9bb42954cf8f72673bd0aad0a6a5 Gerrit-PatchSet: 1 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Piotr Kliczewski <piotr.kliczewski(a)gmail.com>

2 2

Change in vdsm[master]: jsonrpcvdscli: improve functional network tests duration time
by Piotr Kliczewski 16 Nov '15

16 Nov '15

Piotr Kliczewski has uploaded a new change for review. Change subject: jsonrpcvdscli: improve functional network tests duration time ...................................................................... jsonrpcvdscli: improve functional network tests duration time The tests were creating new jsonrpcvdscli#_Server every time before test invocation. In __init__ method we perform schema parsing which is time consuming operation. We improved duration time of the test by creating the objects only once instead of before every test method. Change-Id: Id1fd202566edd389f06d49876e5b83391686b53b Signed-off-by: pkliczewski <piotr.kliczewski(a)gmail.com> --- M tests/functional/networkTests.py 1 file changed, 4 insertions(+), 2 deletions(-) git pull ssh://gerrit.ovirt.org:29418/vdsm refs/changes/56/48356/1 diff --git a/tests/functional/networkTests.py b/tests/functional/networkTests.py index 3f4053e..a00e042 100644 --- a/tests/functional/networkTests.py +++ b/tests/functional/networkTests.py @@ -204,8 +204,10 @@ @expandPermutations class NetworkTest(TestCaseBase): - def setUp(self): - self.vdsm_net = VdsProxy() + @classmethod + def setUpClass(cls): + cls._patch_arch.apply() + cls.vdsm_net = VdsProxy() def cleanupNet(func): """ -- To view, visit https://gerrit.ovirt.org/48356 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: newchange Gerrit-Change-Id: Id1fd202566edd389f06d49876e5b83391686b53b Gerrit-PatchSet: 1 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Piotr Kliczewski <piotr.kliczewski(a)gmail.com>

3 6

Change in vdsm[master]: hooks: ovs: remove unused parameter
by phoracek＠redhat.com 16 Nov '15

16 Nov '15

Petr Horáček has uploaded a new change for review. Change subject: hooks: ovs: remove unused parameter ...................................................................... hooks: ovs: remove unused parameter Change-Id: Ib7d39a103d3c07ee46a7bc6cf17fe33165117f69 Signed-off-by: Petr Horáček <phoracek(a)redhat.com> --- M vdsm_hooks/ovs/ovs_before_network_setup_ovs.py 1 file changed, 1 insertion(+), 1 deletion(-) git pull ssh://gerrit.ovirt.org:29418/vdsm refs/changes/67/48267/1 diff --git a/vdsm_hooks/ovs/ovs_before_network_setup_ovs.py b/vdsm_hooks/ovs/ovs_before_network_setup_ovs.py index 9c5cd5b..027da90 100644 --- a/vdsm_hooks/ovs/ovs_before_network_setup_ovs.py +++ b/vdsm_hooks/ovs/ovs_before_network_setup_ovs.py @@ -128,7 +128,7 @@ return commands -def _add_nic_port(net, vlan, nic, nets_by_nic): +def _add_nic_port(net, nic, nets_by_nic): if nic in nets_by_nic: nets_by_nic[nic].add(net) else: -- To view, visit https://gerrit.ovirt.org/48267 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: newchange Gerrit-Change-Id: Ib7d39a103d3c07ee46a7bc6cf17fe33165117f69 Gerrit-PatchSet: 1 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Petr Horáček <phoracek(a)redhat.com>

3 5

Change in vdsm[master]: asyncore: remove misleading log entry
by Piotr Kliczewski 16 Nov '15

16 Nov '15

Piotr Kliczewski has uploaded a new change for review. Change subject: asyncore: remove misleading log entry ...................................................................... asyncore: remove misleading log entry >From time to time I can see misleading warning in the logs: betterAsyncore::144::vds.dispatcher::(log_info) unhandled close event In order to get rid of it we make sure that we handle close event for all the dispatchers that we have and we call close on dispatcher. Change-Id: Ib35eb35c7ffe52b090c329136041bc21694fbdaf Signed-off-by: pkliczewski <piotr.kliczewski(a)gmail.com> --- M lib/vdsm/sslutils.py M vdsm/protocoldetector.py 2 files changed, 9 insertions(+), 0 deletions(-) git pull ssh://gerrit.ovirt.org:29418/vdsm refs/changes/75/48375/1 diff --git a/lib/vdsm/sslutils.py b/lib/vdsm/sslutils.py index 443ae8c..3b52a81 100644 --- a/lib/vdsm/sslutils.py +++ b/lib/vdsm/sslutils.py @@ -297,6 +297,9 @@ self.want_read = self.want_write = True self._is_handshaking = False + def handle_close(self, dispatcher): + dispatcher.close() + def create_ssl_context(): sslctx = None diff --git a/vdsm/protocoldetector.py b/vdsm/protocoldetector.py index 0bcc7a6..af7818d 100644 --- a/vdsm/protocoldetector.py +++ b/vdsm/protocoldetector.py @@ -72,6 +72,9 @@ *client.getpeername()) self._dispatcher_factory(client) + def handle_close(self, dispatcher): + dispatcher.close() + class _ProtocolDetector(object): log = logging.getLogger("ProtocolDetector.Detector") @@ -128,6 +131,9 @@ def has_expired(self): return monotonic_time() >= self._give_up_at + def handle_close(self, dispatcher): + dispatcher.close() + class MultiProtocolAcceptor: """ -- To view, visit https://gerrit.ovirt.org/48375 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: newchange Gerrit-Change-Id: Ib35eb35c7ffe52b090c329136041bc21694fbdaf Gerrit-PatchSet: 1 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Piotr Kliczewski <piotr.kliczewski(a)gmail.com>

2 2

Change in vdsm[master]: gluster: Set mount path based on gluster volume info
by ahino＠redhat.com 16 Nov '15

16 Nov '15

Ala Hino has uploaded a new change for review. Change subject: gluster: Set mount path based on gluster volume info ...................................................................... gluster: Set mount path based on gluster volume info There are cases where gluter server and ovirt are configured differently regarding ip addresses and domain names. To avoid any issues that could happen due to this misconfiguration, we have to use info retuned from gluster volume info to set the mount path as well as the backup-volfile-servers. Change-Id: Id3386b37cd407c52e1b8f38d54c236bffc143e2f Signed-off-by: Ala Hino <ahino(a)redhat.com> --- M vdsm/storage/storageServer.py 1 file changed, 1 insertion(+), 0 deletions(-) git pull ssh://gerrit.ovirt.org:29418/vdsm refs/changes/08/48308/1 diff --git a/vdsm/storage/storageServer.py b/vdsm/storage/storageServer.py index 6636bd8..a6fe39b 100644 --- a/vdsm/storage/storageServer.py +++ b/vdsm/storage/storageServer.py @@ -336,6 +336,7 @@ raise se.UnsupportedGlusterVolumeReplicaCountError(replicaCount) def _get_backup_servers_option(self): + self._volfileserver = self.volinfo['bricks'][0].split(":")[0] servers = [brick.split(":")[0] for brick in self.volinfo['bricks']] servers.remove(self._volfileserver) if not servers: -- To view, visit https://gerrit.ovirt.org/48308 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: newchange Gerrit-Change-Id: Id3386b37cd407c52e1b8f38d54c236bffc143e2f Gerrit-PatchSet: 1 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Ala Hino <ahino(a)redhat.com>

4 27

Change in vdsm[master]: vm: add support for "Crashed" event
by fromani＠redhat.com 16 Nov '15

16 Nov '15

Francesco Romani has uploaded a new change for review. Change subject: vm: add support for "Crashed" event ...................................................................... vm: add support for "Crashed" event Libvirt recently added this event. We seen this first on libvirt 1.2.17 on ppc64le. Change-Id: I96e98cf7dc9c2c9e7507cc39e181fb2953032989 Related-To: https://bugzilla.redhat.com/1273891 Backport-To: 3.6 Signed-off-by: Francesco Romani <fromani(a)redhat.com> --- M vdsm/virt/vm.py 1 file changed, 1 insertion(+), 0 deletions(-) git pull ssh://gerrit.ovirt.org:29418/vdsm refs/changes/94/48594/1 diff --git a/vdsm/virt/vm.py b/vdsm/virt/vm.py index 7dd0247..6ea0ff3 100644 --- a/vdsm/virt/vm.py +++ b/vdsm/virt/vm.py @@ -167,6 +167,7 @@ "Stopped", "Shutdown", "PM-Suspended", + "Crashed", ) -- To view, visit https://gerrit.ovirt.org/48594 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: newchange Gerrit-Change-Id: I96e98cf7dc9c2c9e7507cc39e181fb2953032989 Gerrit-PatchSet: 1 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Francesco Romani <fromani(a)redhat.com>

3 3

← Newer
1
...
7
8
9
10
11
12
13
...
41
Older →

Jump to page:

2024

2023

2022

2021

2020

2019

2018

2017

2016

2015

2014

2013

2012

2011

vdsm-patches November 2015