From Dan Kenigsberg <danken(a)redhat.com>:
Dan Kenigsberg has posted comments on this change.
Change subject: net: tests: Migrate testFailWithInvalidParams to the new func tests
......................................................................
Patch Set 2: Code-Review-1
requires manual rebase
--
To view, visit https://gerrit.ovirt.org/79905
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I848f360e3e4f0e8cda17870f53ce27af25252343
Gerrit-PatchSet: 2
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Leon Goldberg <lgoldber(a)redhat.com>
Gerrit-Reviewer: Dan Kenigsberg <danken(a)redhat.com>
Gerrit-Reviewer: Edward Haas <edwardh(a)redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Leon Goldberg <lgoldber(a)redhat.com>
Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>
Gerrit-HasComments: No
From Dan Kenigsberg <danken(a)redhat.com>:
Dan Kenigsberg has submitted this change and it was merged. ( https://gerrit.ovirt.org/79438 )
Change subject: net: tests: Migrate testFailWithInvalidIpConfig to the new func tests
......................................................................
net: tests: Migrate testFailWithInvalidIpConfig to the new func tests
Change-Id: I4a46e5e5e210fd4d17b70d1f77405ffbadedb44d
Signed-off-by: Leon Goldberg <lgoldber(a)redhat.com>
---
M tests/functional/networkTests.py
A tests/network/func_net_ip_test.py
2 files changed, 75 insertions(+), 16 deletions(-)
Approvals:
Jenkins CI: Passed CI tests
Leon Goldberg: Verified
Edward Haas: Looks good to me, approved
--
To view, visit https://gerrit.ovirt.org/79438
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I4a46e5e5e210fd4d17b70d1f77405ffbadedb44d
Gerrit-PatchSet: 11
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Leon Goldberg <lgoldber(a)redhat.com>
Gerrit-Reviewer: Dan Kenigsberg <danken(a)redhat.com>
Gerrit-Reviewer: Edward Haas <edwardh(a)redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Leon Goldberg <lgoldber(a)redhat.com>
Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>
From Dan Kenigsberg <danken(a)redhat.com>:
Dan Kenigsberg has uploaded a new change for review.
Change subject: net test: use static bonding defaults if dump fails
......................................................................
net test: use static bonding defaults if dump fails
sysfs_options_mapper.dump_bonding_options may fail during the test if
its target directory is missing. In such a case, take the shipped
defaults.
Change-Id: I33a6ecc14f6d1a2f7cc9da9bfaff4fad13fa8055
Signed-off-by: Dan Kenigsberg <danken(a)redhat.com>
---
M tests/network/nettestlib.py
1 file changed, 7 insertions(+), 2 deletions(-)
git pull ssh://gerrit.ovirt.org:29418/vdsm refs/changes/89/79889/1
diff --git a/tests/network/nettestlib.py b/tests/network/nettestlib.py
index 7395755..79f55f4 100644
--- a/tests/network/nettestlib.py
+++ b/tests/network/nettestlib.py
@@ -532,13 +532,18 @@
bonding_name2num_fpath = ALTERNATIVE_BONDING_NAME2NUMERIC_PATH
if _has_sysfs_bond_permission():
- sysfs_options_mapper.dump_bonding_options()
+ try:
+ sysfs_options_mapper.dump_bonding_options()
+ except SystemError as e:
+ if e.errno != errno.ENOENT:
+ raise
if os.path.exists(BONDING_DEFAULTS):
bonding_defaults_fpath = BONDING_DEFAULTS
if os.path.exists(sysfs_options_mapper.BONDING_NAME2NUMERIC_PATH):
- bonding_name2num_fpath = sysfs_options_mapper.BONDING_NAME2NUMERIC_PATH
+ bonding_name2num_fpath = \
+ sysfs_options_mapper.BONDING_NAME2NUMERIC_PATH
return bonding_defaults_fpath, bonding_name2num_fpath
--
To view, visit https://gerrit.ovirt.org/79889
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: newchange
Gerrit-Change-Id: I33a6ecc14f6d1a2f7cc9da9bfaff4fad13fa8055
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Dan Kenigsberg <danken(a)redhat.com>
From Dan Kenigsberg <danken(a)redhat.com>:
Dan Kenigsberg has uploaded a new change for review.
Change subject: testrunner: mock vdsm.common.constants.P_VDSM
......................................................................
testrunner: mock vdsm.common.constants.P_VDSM
As long as we keep vdsm.constants as proxy to vdsm.common.constants, we
need to keep them align also when mocked.
Change-Id: I39231c2e9d4b883de0294d90f42860d72edc67f4
Signed-off-by: Dan Kenigsberg <danken(a)redhat.com>
---
M tests/testrunner.py
1 file changed, 2 insertions(+), 1 deletion(-)
git pull ssh://gerrit.ovirt.org:29418/vdsm refs/changes/11/79911/1
diff --git a/tests/testrunner.py b/tests/testrunner.py
index e4dab3b..7586158 100644
--- a/tests/testrunner.py
+++ b/tests/testrunner.py
@@ -49,6 +49,7 @@
"instead of installed ones.\n")
if findRemove(sys.argv, "--local-modules"):
from vdsm import constants
- constants.P_VDSM = "../vdsm/"
+ from vdsm.common import common_constants
+ common_constants.P_VDSM = constants.P_VDSM = "../vdsm/"
testlib.run()
--
To view, visit https://gerrit.ovirt.org/79911
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: newchange
Gerrit-Change-Id: I39231c2e9d4b883de0294d90f42860d72edc67f4
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Dan Kenigsberg <danken(a)redhat.com>
From Dan Kenigsberg <danken(a)redhat.com>:
Dan Kenigsberg has posted comments on this change.
Change subject: storage: Add LibgfApi support as additional feature
......................................................................
Patch Set 6: Code-Review+2
--
To view, visit https://gerrit.ovirt.org/79605
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I0aac04c144ae647aad1c0714379246060f4e991f
Gerrit-PatchSet: 6
Gerrit-Project: vdsm
Gerrit-Branch: ovirt-4.1
Gerrit-Owner: Denis Chaplygin <dchaplyg(a)redhat.com>
Gerrit-Reviewer: Adam Litke <alitke(a)redhat.com>
Gerrit-Reviewer: Dan Kenigsberg <danken(a)redhat.com>
Gerrit-Reviewer: Denis Chaplygin <dchaplyg(a)redhat.com>
Gerrit-Reviewer: Francesco Romani <fromani(a)redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Nir Soffer <nsoffer(a)redhat.com>
Gerrit-Reviewer: Raz Tamir <ratamir(a)redhat.com>
Gerrit-Reviewer: Sahina Bose <sabose(a)redhat.com>
Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>
Gerrit-HasComments: No
From Yaniv Bronhaim <ybronhei(a)redhat.com>:
Yaniv Bronhaim has posted comments on this change.
Change subject: m2c: uses different protocol constant names
......................................................................
Patch Set 3: Code-Review+2
(1 comment)
https://gerrit.ovirt.org/#/c/79664/3/lib/vdsm/m2cutils.py
File lib/vdsm/m2cutils.py:
Line 331: excludes = 0
Line 332:
Line 333: for no_protocol in config.get('vars', 'ssl_excludes').split(','):
Line 334: if no_protocol != '':
Line 335: protocol = 'SSL_' + no_protocol.strip()
> SSL_OP_NO_TLSv1_1 is not supported. Only two values are supported as specif
didn't we say that we'll just support both ..? you agreed. just add the SSL_ prefix if it was not provided.
But I don't mind to restrict it.
Line 336: if protocol == 'SSL_OP_NO_TLSv1_1':
Line 337: # not all m2crypto provide this constant
Line 338: excludes |= 268435456
Line 339: else:
--
To view, visit https://gerrit.ovirt.org/79664
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I6c05bddfba94d85e2c48122b6fd56d8f336d01f5
Gerrit-PatchSet: 3
Gerrit-Project: vdsm
Gerrit-Branch: ovirt-4.1
Gerrit-Owner: Piotr Kliczewski <piotr.kliczewski(a)gmail.com>
Gerrit-Reviewer: Dan Kenigsberg <danken(a)redhat.com>
Gerrit-Reviewer: Francesco Romani <fromani(a)redhat.com>
Gerrit-Reviewer: Irit Goihman <igoihman(a)redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Piotr Kliczewski <piotr.kliczewski(a)gmail.com>
Gerrit-Reviewer: Yaniv Bronhaim <ybronhei(a)redhat.com>
Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>
Gerrit-HasComments: Yes
From Dan Kenigsberg <danken(a)redhat.com>:
Dan Kenigsberg has posted comments on this change.
Change subject: Revert "Revert "storage: Made diskType a real property.""
......................................................................
Patch Set 2: Code-Review+2
--
To view, visit https://gerrit.ovirt.org/79800
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: Id98229bd3705fc056d54d9eb536d74c7b7729f47
Gerrit-PatchSet: 2
Gerrit-Project: vdsm
Gerrit-Branch: ovirt-4.1
Gerrit-Owner: Denis Chaplygin <dchaplyg(a)redhat.com>
Gerrit-Reviewer: Dan Kenigsberg <danken(a)redhat.com>
Gerrit-Reviewer: Francesco Romani <fromani(a)redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Nir Soffer <nsoffer(a)redhat.com>
Gerrit-HasComments: No
From Dan Kenigsberg <danken(a)redhat.com>:
Dan Kenigsberg has posted comments on this change.
Change subject: Revert "Revert "storage: Added disk type change logging""
......................................................................
Patch Set 2: Code-Review+2
--
To view, visit https://gerrit.ovirt.org/79801
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: Ia2e875c82b672384d04b23907292a8b7dfd5dcc3
Gerrit-PatchSet: 2
Gerrit-Project: vdsm
Gerrit-Branch: ovirt-4.1
Gerrit-Owner: Denis Chaplygin <dchaplyg(a)redhat.com>
Gerrit-Reviewer: Dan Kenigsberg <danken(a)redhat.com>
Gerrit-Reviewer: Francesco Romani <fromani(a)redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Nir Soffer <nsoffer(a)redhat.com>
Gerrit-HasComments: No