Daniel Erez has posted comments on this change.
Change subject: getDeviceList - passing includePartitioned to HSM ......................................................................
Patch Set 2: (2 inline comments)
.................................................... File vdsm_cli/vdsClient.py Line 548: storageType = int(args[0]) if len(args) > 0 else 0 Currently, the signature of 'getDeviceList' method is: getDeviceList(self, storageType=None, options={})
Isn't 'storageType=None' enough? Or, should I simply replace: - 'storageType = int(args[0]) if len(args) > 0 else 0' with 'storageType = args[0] if len(args) > 0 else None'
Line 555: except: 'options.get' throws an exception when 'options' is not a dictionary. Hence, the CLI outputs an error stack - is it an acceptable behavior?
-- To view, visit http://gerrit.ovirt.org/4828 To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment Gerrit-Change-Id: I388442f361ea4ae00e3d8878a2497c7819ab2214 Gerrit-PatchSet: 2 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Daniel Erez derez@redhat.com Gerrit-Reviewer: Ayal Baron abaron@redhat.com Gerrit-Reviewer: Dan Kenigsberg danken@redhat.com Gerrit-Reviewer: Daniel Erez derez@redhat.com Gerrit-Reviewer: Eduardo ewarszaw@redhat.com