Federico Simoncelli has posted comments on this change.
Change subject: Add hotPlug/hotUnplug disk feature ......................................................................
Patch Set 3: (2 inline comments)
Comments are in the patch set 3.
.................................................... File vdsm/clientIF.py Line 655: curVm = self.vmContainer[params['vmId']] It's raceful because the vm might still be in the vmContainer but the qemu-kvm process died (and we're still in the process of cleaning up). We want to return the noVM error in both cases.
.................................................... File vdsm/vm.py Line 390: self._devices[DISK_DEVICES].remove(d) Didn't you override the __eq__ method to check the unique id? "remove()" removes the first occurrence of value.
-- To view, visit http://gerrit.ovirt.org/1108 To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment Gerrit-Change-Id: Iecab9e28b2e77cfeedc3b9068095f7d117eb6221 Gerrit-PatchSet: 3 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Igor Lvovsky ilvovsky@redhat.com Gerrit-Reviewer: Federico Simoncelli fsimonce@redhat.com Gerrit-Reviewer: Igor Lvovsky ilvovsky@redhat.com Gerrit-Reviewer: Saggi Mizrahi smizrahi@redhat.com