From Dan Kenigsberg danken@redhat.com:
Dan Kenigsberg has posted comments on this change.
Change subject: vdsm-tool: Don't configure firewalld unless required in vdsm.conf ......................................................................
Patch Set 6: Code-Review-1
(2 comments)
https://gerrit.ovirt.org/#/c/75099/6/lib/vdsm/config.py.in File lib/vdsm/config.py.in:
PS6, Line 265: ' why's the apostrophe? (It may seem that I'm in a crusade against them...)
https://gerrit.ovirt.org/#/c/75099/6/lib/vdsm/tool/configurators/firewalld.p... File lib/vdsm/tool/configurators/firewalld.py:
Line 67: _add_to_required_services('vdsm.gluster.api', ('glusterfs', 'samba', 'nfs')) Line 68: _add_to_required_services('cockpit', ('cockpit',)) Line 69: Line 70: Line 71: def configure(): to rephrase my comment:
if for some reason someone runs
vdsm-tool configure
without checking
vdsm-tool is-configured
first, your could would configure firewalld regardless of the value in vdsm.conf. Line 72: if service_status('firewalld') == 1: Line 73: service_start('firewalld') Line 74: Line 75: fw_client = FirewallClient()