Idan Shaby has posted comments on this change.
Change subject: lvm: Update hsm.__processVGInfos() with lvm.getPV() new API ......................................................................
Patch Set 1:
(1 comment)
https://gerrit.ovirt.org/#/c/38421/1/vdsm/storage/hsm.py File vdsm/storage/hsm.py:
Line 3003: try: Line 3004: pvInfo = lvm.getPV(pv) Line 3005: except se.InaccessiblePhysDev: Line 3006: self.log.error("PV %s no longer exists", pv) Line 3007: continue
Does this mean that now getVGInfo and getVGList may silently return incompl
Previously we got None in pvInfo and when we tried to access its attributes we got an AttributeError. Now all we do is skip this pv and log the error. I think it's a better feedback than an exception, isn't it? Line 3008: vgInfo['pvlist'].append(self.__fillPVDict(dev, pvInfo, vgType)) Line 3009: Line 3010: if vgType == multipath.DEV_FCP: Line 3011: vgType = sd.FCP_DOMAIN