Yaniv Bronhaim has posted comments on this change.
Change subject: pep8: use multiline blacklist ......................................................................
Patch Set 2: Code-Review+1
(1 comment)
http://gerrit.ovirt.org/#/c/25416/2/Makefile.am File Makefile.am:
Line 71: $(PEP8) --version Line 72: for x in $(PEP8_BLACKLIST); do \ Line 73: exclude="$${exclude},$${x}" ; \ Line 74: done ; \ Line 75: $(PEP8) --exclude=$${exclude} --filename '*.py,*.py.in' . i didn't think about that... good point for not having the list Line 76: @if test -f .gitignore; then \ Line 77: for i in `git ls-files *.in`; do \ Line 78: if ! grep -q -x $${i%%.in} .gitignore; then \ Line 79: echo "Missing $${i%%.in} in .gitignore"; exit 1; fi; \