Dan Kenigsberg has posted comments on this change.
Change subject: vdsm/storage/misc.py: ensure uuid input is str or unicode for regex ......................................................................
Patch Set 2: Fails
I now see that testInvalidInputNotHex and testWrongLength tests fail.
You may want to add another test for the integer input, so that preferred behavior is maintained in the future.
-- To view, visit http://gerrit.ovirt.org/3687 To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment Gerrit-Change-Id: If16466e88a50d3af03ae7830d4d8148ebf69d0d9 Gerrit-PatchSet: 2 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Ryan Harper ryanh@us.ibm.com Gerrit-Reviewer: Dan Kenigsberg danken@redhat.com Gerrit-Reviewer: Lei Li lilei@linux.vnet.ibm.com Gerrit-Reviewer: Ryan Harper ryanh@us.ibm.com