Dan Kenigsberg has posted comments on this change.
Change subject: vdsm/storage/misc.py: ensure uuid input is str or unicode for regex ......................................................................
Patch Set 3: (1 inline comment)
-1 for visibility, code is fine
.................................................... File vdsm/storage/misc.py Line 490: if isinstance(uuid, str) or isinstance(uuid, unicode): that's not the end of the world; I just wonder why you insistently avoid the standard
isinstance(uuid, basestr)
check.
-- To view, visit http://gerrit.ovirt.org/3687 To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment Gerrit-Change-Id: If16466e88a50d3af03ae7830d4d8148ebf69d0d9 Gerrit-PatchSet: 3 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Ryan Harper ryanh@us.ibm.com Gerrit-Reviewer: Dan Kenigsberg danken@redhat.com Gerrit-Reviewer: Lei Li lilei@linux.vnet.ibm.com Gerrit-Reviewer: Ryan Harper ryanh@us.ibm.com