Edward Haas has posted comments on this change.
Change subject: net: netinfo.dhcp - dhcp info update refactoring ......................................................................
Patch Set 1:
(1 comment)
https://gerrit.ovirt.org/#/c/61457/1/lib/vdsm/network/netinfo/dhcp.py File lib/vdsm/network/netinfo/dhcp.py:
PS1, Line 27: dev_info['dhcpv4'] = network_info['dhcpv4'] : dev_info['dhcpv6'] = network_info['dhcpv6']
shouldn't this be the other way around? network_info[...] = dev_info[...]?
Nope, it is setting the net device dhcp data, copying it from the already updated network data. (same logic as the original)