From Yaniv Bronhaim ybronhei@redhat.com:
Yaniv Bronhaim has posted comments on this change.
Change subject: RPC: Refactor ClientRpcTransportAdapter ......................................................................
Patch Set 18: Code-Review-1
(3 comments)
https://gerrit.ovirt.org/#/c/78655/18/lib/yajsonrpc/__init__.py File lib/yajsonrpc/__init__.py:
Line 478 Line 479 Line 480 Line 481 Line 482 please do this change in separate patch. it doesn't look related. just removal of redundant code which is awesome!
https://gerrit.ovirt.org/#/c/78655/18/lib/yajsonrpc/stompreactor.py File lib/yajsonrpc/stompreactor.py:
Line 584: Line 585: """ Line 586: In order to process message we need to set message Line 587: handler which is responsible for processing jsonrpc Line 588: content of the message. now we have only 1 handler? specify what type of handle i can set here Line 589: """ Line 590: def set_message_handler(self, handler): Line 591: self._message_handler = handler Line 592:
Line 610: def unsubscribe(self, sub): Line 611: self._client.unsubscribe(sub) Line 612: Line 613: def _handle_message(self, sub, frame): Line 614: self._message_handler(frame.body) please do this change in separate patch. it doesn't look related. just removal of redundant code which is awesome! Line 615: Line 616: def close(self): Line 617: self._sub.unsubscribe() Line 618: self._client.close()