Dan Kenigsberg has posted comments on this change.
Change subject: qemuimg: Create qcow2 compat 0.10 images ......................................................................
Patch Set 1:
(1 comment)
http://gerrit.ovirt.org/#/c/33022/1/lib/vdsm/qemuImg.py File lib/vdsm/qemuImg.py:
Line 118: if rc != 0: Line 119: raise QImgError(rc, out, err) Line 120: Line 121: Line 122: def _supports_qcow2_compat():
no because if qemu-img is updated you're in trouble.
I don't expect a qemu-0.10 -> qemu-1.1 upgrade while Vdsm is running.
But we can live with this repetitive check for a while. Line 123: """ Line 124: TODO: Remove this when qemu versions providing the "compat" option are Line 125: available on all platforms. Line 126: """