Dan Kenigsberg has posted comments on this change.
Change subject: Make link state change monitoring use an async proc ......................................................................
Patch Set 3: Code-Review+2
(1 comment)
.................................................... File tests/functional/networkTests.py Line 91: finally: Line 92: monitoringProc.kill() Line 93: out, _ = monitoringProc.communicate() Line 94: changes = [] Line 95: for line in out.splitlines(): It would have been nicer to skip line.startswith(' '). Line 96: tokens = line.split() Line 97: if '%s:' % device == tokens[1]: Line 98: changes.append(tokens[-1]) Line 99: if changes: