Federico Simoncelli has posted comments on this change.
Change subject: Add hotPlug/hotUnplug disk feature ......................................................................
Patch Set 3: I would prefer that you didn't submit this
(4 inline comments)
-1 because I like the saggi's spacing :) ...and to raise your attention to the VIR_ERR_NO_DOMAIN error code.
.................................................... File vdsm/clientIF.py Line 655: curVm = self.vmContainer[params['vmId']] Isn't this raceful? We should probably trap the VIR_ERR_NO_DOMAIN error later on in the libvirt call.
.................................................... File vdsm/libvirtvm.py Line 1292: except libvirt.libvirtError, e: Check here the exception for VIR_ERR_NO_DOMAIN.
Line 1320: except libvirt.libvirtError, e: Check here the exception for VIR_ERR_NO_DOMAIN.
.................................................... File vdsm/vm.py Line 390: self._devices[DISK_DEVICES].remove(d) Doesn't this line does already all the work? (It removes the element d if present, no need to loop)
-- To view, visit http://gerrit.ovirt.org/1108 To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment Gerrit-Change-Id: Iecab9e28b2e77cfeedc3b9068095f7d117eb6221 Gerrit-PatchSet: 3 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Igor Lvovsky ilvovsky@redhat.com Gerrit-Reviewer: Federico Simoncelli fsimonce@redhat.com Gerrit-Reviewer: Igor Lvovsky ilvovsky@redhat.com Gerrit-Reviewer: Saggi Mizrahi smizrahi@redhat.com