From Dan Kenigsberg danken@redhat.com:
Dan Kenigsberg has posted comments on this change.
Change subject: introduce common.constants
......................................................................
Patch Set 3:
I prefer to put in common.constants only truly-common , and avoid the ones that should actually reside in a specific subpackage or even module.
Moving constants.py (and keeping from common.constants import *) is clearly easier, but it would keep the constants junkyard for even longer.
--
To view, visit
https://gerrit.ovirt.org/79692
To unsubscribe, visit
https://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I8568a806f9195007620d15eff59e72b55042557b
Gerrit-PatchSet: 3
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Dan Kenigsberg
danken@redhat.com
Gerrit-Reviewer: Dan Kenigsberg
danken@redhat.com
Gerrit-Reviewer: Edward Haas
edwardh@redhat.com
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Nir Soffer
nsoffer@redhat.com
Gerrit-Reviewer: gerrit-hooks
automation@ovirt.org
Gerrit-HasComments: No