Nir Soffer has posted comments on this change.
Change subject: lvm: Update hsm.__processVGInfos() with lvm.getPV() new API ......................................................................
Patch Set 1:
(1 comment)
https://gerrit.ovirt.org/#/c/38421/1/vdsm/storage/hsm.py File vdsm/storage/hsm.py:
Line 3003: try: Line 3004: pvInfo = lvm.getPV(pv) Line 3005: except se.InaccessiblePhysDev: Line 3006: self.log.error("PV %s no longer exists", pv) Line 3007: continue
Does this mean that now getVGInfo and getVGList may silently return incompl
Previously the entire request was failing with AttributeError, now the request will return the available pvs.
It would be nice if we can return info about missing pvs, but it is not the scope of this patch.
lvm.getPV() could return a missing pv in this case, or we can add MissingPV namedduple for feeding __fillPVDict() Line 3008: vgInfo['pvlist'].append(self.__fillPVDict(dev, pvInfo, vgType)) Line 3009: Line 3010: if vgType == multipath.DEV_FCP: Line 3011: vgType = sd.FCP_DOMAIN