Nir Soffer has posted comments on this change.
Change subject: [WIP] core: Expose API for qemuimg commit ......................................................................
Patch Set 4:
(1 comment)
https://gerrit.ovirt.org/#/c/64222/4/tests/qemuimg_test.py File tests/qemuimg_test.py:
Line 369: # base now should include original data and top's data Line 370: qemu_pattern_verify(base, qemuimg.FORMAT.RAW, '0', 0xf2) Line 371: qemu_pattern_verify(base, qemuimg.FORMAT.RAW, '512', 0xf1) Line 372: Line 373: @MonkeyPatch(qemuimg, 'config', CONFIG) Running this with both raw and qcow base can be useful to detect qemu-img regression, and cost almost nothing. Line 374: def test_commit_backing_chain(self): Line 375: with namedTemporaryDir() as tmpdir: Line 376: base = os.path.join(tmpdir, 'base.img') Line 377: internal = os.path.join(tmpdir, 'internal.img')