Igor Lvovsky has posted comments on this change.
Change subject: Add hotPlug/hotUnplug disk feature ......................................................................
Patch Set 5: (1 inline comment)
.................................................... File vdsm/libvirtvm.py Line 1284: self._devices[vm.DISK_DEVICES].append(drive) Yes, it was like this before but I changed it because anyway you will get race here and I am not sure what is better. 1. you scenario is right, in this case we will get less members in _devices and self.conf but during recovery we will fill it from libvirt. 2. In oposite case we may get more disks in _devices and conf but not in real VM. So, w'll need somehow clean it in recovery
-- To view, visit http://gerrit.ovirt.org/1108 To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment Gerrit-Change-Id: Iecab9e28b2e77cfeedc3b9068095f7d117eb6221 Gerrit-PatchSet: 5 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Igor Lvovsky ilvovsky@redhat.com Gerrit-Reviewer: Dan Kenigsberg danken@redhat.com Gerrit-Reviewer: Federico Simoncelli fsimonce@redhat.com Gerrit-Reviewer: Igor Lvovsky ilvovsky@redhat.com Gerrit-Reviewer: Saggi Mizrahi smizrahi@redhat.com