Nir Soffer has posted comments on this change.
Change subject: netinfo: Replace misused asserts with InvalidConfiguration ......................................................................
Patch Set 1:
(1 comment)
http://gerrit.ovirt.org/#/c/34361/1/lib/vdsm/netinfo.py File lib/vdsm/netinfo.py:
Line 859: for port in ports: Line 860: if port in self.vlans: Line 861: if vlan is not None: Line 862: raise InvalidConfiguration( Line 863: "Unexpected vlan: %s exepected: None" % (vlan,))
I recommend a comma to separate values visually :-)
Feel free to post the next revision with this change. As a bonus, I'll let you verify this patch :-) Line 864: nic = getVlanDevice(port) Line 865: vlan = getVlanID(port) Line 866: if self.vlans[port]['iface'] != nic: Line 867: raise InvalidConfiguration(