Nir Soffer has uploaded a new change for review.
Change subject: sd: Remove unused variable and evil thread ......................................................................
sd: Remove unused variable and evil thread
If storage domain had a non-null start instance variable, we used to start a thread stopping this stat object in __del__(!). Fortunately, stat is always None, so we don't need to stop it.
Change-Id: I2f17e591bcd03b83a0df5b8e2a31835bcd572064 Signed-off-by: Nir Soffer nsoffer@redhat.com --- M tests/sdm_indirection_tests.py M vdsm/storage/sd.py 2 files changed, 0 insertions(+), 7 deletions(-)
git pull ssh://gerrit.ovirt.org:29418/vdsm refs/changes/20/63520/1
diff --git a/tests/sdm_indirection_tests.py b/tests/sdm_indirection_tests.py index 7b2028d..7501983 100644 --- a/tests/sdm_indirection_tests.py +++ b/tests/sdm_indirection_tests.py @@ -272,7 +272,6 @@ manifestClass = FakeBlockDomainManifest
def __init__(self): - self.stat = None self._manifest = self.manifestClass()
@@ -280,7 +279,6 @@ manifestClass = FakeFileDomainManifest
def __init__(self): - self.stat = None self._manifest = self.manifestClass()
diff --git a/vdsm/storage/sd.py b/vdsm/storage/sd.py index 9d0a892..ebc899d 100644 --- a/vdsm/storage/sd.py +++ b/vdsm/storage/sd.py @@ -535,11 +535,6 @@ def __init__(self, manifest): self._manifest = manifest self._lock = threading.Lock() - self.stat = None - - def __del__(self): - if self.stat: - concurrent.thread(self.stat.stop).start()
@property def sdUUID(self):