Michal Skrivanek has posted comments on this change.
Change subject: vm: hyperv: initial windows hyperv support ......................................................................
Patch Set 5:
(1 comment)
http://gerrit.ovirt.org/#/c/27619/5/vdsm/virt/vm.py File vdsm/virt/vm.py:
Line 716: """ Line 717: Line 718: if (self.arch == caps.Architecture.X86_64 and Line 719: utils.tobool(self.conf.get('hypervEnable', 'false'))): Line 720: clockName = 'hypervclock'
this is not available until libvirt 1.2.2. - and it is not in RHEL 6.5. Pro
can't we check the version instead? The complexity of various level of support of hyperv can be done inside vdsm Line 721: else: Line 722: clockName = 'rtc' Line 723: Line 724: m = XMLElement('clock', offset='variable',