Dan Kenigsberg has posted comments on this change.
Change subject: vdsm: report migration status in getVMList() call ......................................................................
Patch Set 3: I would prefer that you didn't submit this
(1 inline comment)
.................................................... Commit Message Line 7: vdsm: report migration status in getVMList() call Line 8: Line 9: getVMList() is polled by the engine every 3 sec, so it is not the worst place Line 10: for migration statistics — if VM is in the migration state. Thus, the engine Line 11: will be able to track migration progress without explicit call Of course we can dump more stuff in getVmStats, but why should we? Especially when we have a dedicated migStatus verb?
I'm completely missing the motivation here. Line 12: migrationStatus() for each VM. Line 13: Line 14: Signed-off-by: Peter V. Saveliev peet@redhat.com