Dan Kenigsberg has posted comments on this change.
Change subject: Added getMdDeviceUuidMap function in supervdsm. ......................................................................
Patch Set 3: I would prefer that you didn't submit this
(3 inline comments)
.................................................... File tests/md_utils_tests.py Line 25: class mdUtilsTests(TestCaseBase): ClassNamesShouldBeLikeThis
Line 35: self.assertTrue(uuid == '12345695:0b784539:a73e011c:c555adf3') assertEquals, maybe?
.................................................... File vdsm/md_utils.py Line 22: thanks, but please add to pep8 whitelist, so that no one breaks the code style.
-- To view, visit http://gerrit.ovirt.org/3469 To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment Gerrit-Change-Id: I1970fa0ad9125c29b4a96fa614c580682ac5064c Gerrit-PatchSet: 3 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Bala.FA barumuga@redhat.com Gerrit-Reviewer: Bala.FA barumuga@redhat.com Gerrit-Reviewer: Dan Kenigsberg danken@redhat.com Gerrit-Reviewer: Saggi Mizrahi smizrahi@redhat.com Gerrit-Reviewer: Timothy Asir tjeyasin@redhat.com