Dan Kenigsberg has posted comments on this change.
Change subject: Add hotPlug/hotUnplug disk feature ......................................................................
Patch Set 5: I would prefer that you didn't submit this
(1 inline comment)
This patch can come in, with the race, if it is promised to be fixed soon after, but please consider fixing it now.
.................................................... File vdsm/libvirtvm.py Line 1284: self._devices[vm.DISK_DEVICES].append(drive) If we die here, before saveState, we are going to have hard time on recovery. How about first saving, then calling libvirt (and clean self.conf on recovery)?
-- To view, visit http://gerrit.ovirt.org/1108 To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment Gerrit-Change-Id: Iecab9e28b2e77cfeedc3b9068095f7d117eb6221 Gerrit-PatchSet: 5 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Igor Lvovsky ilvovsky@redhat.com Gerrit-Reviewer: Dan Kenigsberg danken@redhat.com Gerrit-Reviewer: Federico Simoncelli fsimonce@redhat.com Gerrit-Reviewer: Igor Lvovsky ilvovsky@redhat.com Gerrit-Reviewer: Saggi Mizrahi smizrahi@redhat.com