Francesco Romani has posted comments on this change.
Change subject: janitorial: vm: switch to response.error() ......................................................................
Patch Set 5:
(1 comment)
https://gerrit.ovirt.org/#/c/38268/5/vdsm/virt/vm.py File vdsm/virt/vm.py:
Line 1588 Line 1589 Line 1590 Line 1591 Line 1592
Is errCode used after this patch?
Yes:
- in _reportError (trivial, fixed in followup patch) - in an handful of places inside the virt package (will fix in followup patches) - in v2v.py (same as above) - in BindingXMLRPC.py (seems easy) - in a few places inside the network package (vdsm/network/), seems easy - in a bunch of places inside API.py and clientIF.py
I will post followup patches to fix the rest of virt and v2v.py once these are merged. Then we will tackle the rest.