Francesco Romani has posted comments on this change.
Change subject: vm: hyperv: initial windows hyperv support ......................................................................
Patch Set 6:
(1 comment)
http://gerrit.ovirt.org/#/c/27619/6/vdsm/virt/vm.py File vdsm/virt/vm.py:
Line 705: Line 706: self._devices = XMLElement('devices') Line 707: self.dom.appendChild(self._devices) Line 708: Line 709: def _isHyperV(self):
do we need the logic regarding arch here? why not rely on engine? (and get
I just want to make sure to not break PPC64. If we choose to fully trust engine and do not add safety nets I'll change the code in near zero time. Line 710: return (self.arch == caps.Architecture.X86_64 and Line 711: utils.tobool(self.conf.get('hypervEnable', 'false'))) Line 712: Line 713: def appendClock(self):