Igor Lvovsky has posted comments on this change.
Change subject: Add hotPlug/hotUnplug disk feature ......................................................................
Patch Set 5: (1 inline comment)
.................................................... File vdsm/libvirtvm.py Line 1284: self._devices[vm.DISK_DEVICES].append(drive) We have almoust all info in libvirt, except several management specific things, like: 'share', 'optional', 'propagateErrors'. In additional I didn't gather things (but I can add it) like 'bootorder', 'readonly', ( PDIV/GUID/UUID ??? - not sure that I can, because I don't know which one this drive)
-- To view, visit http://gerrit.ovirt.org/1108 To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment Gerrit-Change-Id: Iecab9e28b2e77cfeedc3b9068095f7d117eb6221 Gerrit-PatchSet: 5 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Igor Lvovsky ilvovsky@redhat.com Gerrit-Reviewer: Dan Kenigsberg danken@redhat.com Gerrit-Reviewer: Federico Simoncelli fsimonce@redhat.com Gerrit-Reviewer: Igor Lvovsky ilvovsky@redhat.com Gerrit-Reviewer: Saggi Mizrahi smizrahi@redhat.com