Itamar Heim has posted comments on this change.
Change subject: This patch adds some basic debian support ......................................................................
Patch Set 1: (1 inline comment)
i don't feel strongly about the 2nd part of the comment, especially if we don't expect too many more implementations. but moving the key packages to a config per distro seems more robust to future changes
.................................................... File vdsm/caps.py Line 260: if getos() in (OSName.RHEVH, OSName.OVIRT, OSName.FEDORA, OSName.RHEL): doesn't this if statment smells of a config item of: 1. list of key packages per distribution. 2. name of pakcage implementation to use to query?
-- To view, visit http://gerrit.ovirt.org/1110 To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment Gerrit-Change-Id: Ie021cd9f64f80fde2442b6ad7c75c0b5b1c746ff Gerrit-PatchSet: 1 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Matthias Heinz matthias.heinz@goobernetworks.com Gerrit-Reviewer: Dan Kenigsberg danken@redhat.com Gerrit-Reviewer: Itamar Heim iheim@redhat.com