Dan Kenigsberg has posted comments on this change.
Change subject: vm: add optimizations for hyperv ......................................................................
Patch Set 4:
(1 comment)
http://gerrit.ovirt.org/#/c/27619/4/vdsm/virt/vm.py File vdsm/virt/vm.py:
Line 1780: class MissingLibvirtDomainError(Exception): Line 1781: pass Line 1782: Line 1783: Line 1784: class MachineType: When there's "type" with only one element, bells of over-engineering ring. Everywhere else in VM creation, the notion of "instance type" is kept at Engine. Only specific knobs are available to Vdsm.
I suggest to keep this here, and expose a simple enableHyperV boolean. Line 1785: HYPERV = "hyperv" Line 1786: Line 1787: Line 1788: class Vm(object):