Dima Kuznetsov has posted comments on this change.
Change subject: vdsm-tool: Change upgrade mechanism ......................................................................
Patch Set 8:
Assaf, the ordering is truly a bit problematic, because logging facilities only added in a latter patch, http://gerrit.ovirt.org/#/c/27481 but opposite order is not perfect either because the subsequent patch breaks the present-day upgrade mechanism, that assumes it's parameters begin at sys.argv[1:].
As for the logs produced, the following is the actual log (after removing upgrade seals):
MainThread::INFO::2014-05-27 10:29:38,293::netconfpersistence::158::root::(_clearDisk) Clearing /var/run/vdsm/netconf/nets/ and /var/run/vdsm/netconf/bonds/ MainThread::INFO::2014-05-27 10:29:38,294::netconfpersistence::68::root::(setNetwork) Adding network ovirtmgmt({'nic': 'eth0vnet0', 'mtu': 1500, 'bootproto': 'dhcp', 'stp': False, 'bridged': True, 'defaultRoute': True}) MainThread::INFO::2014-05-27 10:29:38,294::netconfpersistence::158::root::(_clearDisk) Clearing /var/run/vdsm/netconf/nets/ and /var/run/vdsm/netconf/bonds/ MainThread::INFO::2014-05-27 10:29:38,294::netconfpersistence::182::root::(save) Saved new config RunningConfig({'ovirtmgmt': {'nic': 'eth0vnet0', 'mtu': 1500, 'bootproto': 'dhcp', 'stp': False, 'bridged': True, 'defaultRoute': True}}, {}) to /var/run/vdsm/netconf/nets/ and /var/run/vdsm/netconf/bonds/