Ondřej Svoboda has posted comments on this change.
Change subject: netinfo: Replace misused asserts with InvalidConfiguration
......................................................................
Patch Set 3:
In getBondingForNic, the assert can be removed.
# ip link add type dummy
# ip link add type bond
# ip link add type bond
# echo +dummy0 > /sys/class/net/bond0/bonding/slaves
# echo +dummy0 > /sys/class/net/bond1/bonding/slaves
-bash: echo: write error: Device or resource busy
getNicsVlanAndBondingForNetwork is too hard to read (because of its complex return value) so I'd prefer to rewrite the function than to add checks to it.
--
To view, visit
https://gerrit.ovirt.org/34361
To unsubscribe, visit
https://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I99ee49aa7e2364f57112e2452e3eab3940b6b00a
Gerrit-PatchSet: 3
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Nir Soffer
nsoffer@redhat.com
Gerrit-Reviewer: Antoni Segura Puimedon
toni+ovirt@midokura.com
Gerrit-Reviewer: Dan Kenigsberg
danken@redhat.com
Gerrit-Reviewer: Ido Barkan
ibarkan@redhat.com
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Nir Soffer
nsoffer@redhat.com
Gerrit-Reviewer: Ondřej Svoboda
osvoboda@redhat.com
Gerrit-Reviewer: Saggi Mizrahi
smizrahi@redhat.com
Gerrit-Reviewer: automation@ovirt.org
Gerrit-HasComments: No