Igor Lvovsky has posted comments on this change.
Change subject: Add hotPlug/hotUnplug disk feature ......................................................................
Patch Set 3: (6 inline comments)
.................................................... File vdsm/clientIF.py Line 655: curVm = self.vmContainer[params['vmId']] Why raceful? I just avoid KeyError here. I already catch libvirtError in libvirt call, but I can add explicitly handling for VIR_ERR_NO_DOMAIN
.................................................... File vdsm/libvirtvm.py Line 1281: diskParams = params.get('drive') I already verified 'drive' existence in upper call function, but I can add {} as default
Line 1284: self._normalizeVdsmImg(diskParams) Done
Line 1288: driveXml = drive.getXML().toprettyxml(encoding='utf-8') Done
Line 1292: except libvirt.libvirtError, e: Done
.................................................... File vdsm/vm.py Line 390: self._devices[DISK_DEVICES].remove(d) No, it doesn't because 'drive' instance may has less attributes. We should to compare it according to unique identifier
-- To view, visit http://gerrit.ovirt.org/1108 To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment Gerrit-Change-Id: Iecab9e28b2e77cfeedc3b9068095f7d117eb6221 Gerrit-PatchSet: 3 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Igor Lvovsky ilvovsky@redhat.com Gerrit-Reviewer: Federico Simoncelli fsimonce@redhat.com Gerrit-Reviewer: Igor Lvovsky ilvovsky@redhat.com Gerrit-Reviewer: Saggi Mizrahi smizrahi@redhat.com