Eduardo has uploaded a new change for review.
Change subject: [WIP] Add cmd_type_1 ......................................................................
[WIP] Add cmd_type_1
Change-Id: I0c62d42936630132722974bcdedd619d13185cde Signed-off-by: Eduardo ewarszaw@redhat.com --- M vdsm/storage/lvm.py 1 file changed, 20 insertions(+), 3 deletions(-)
git pull ssh://gerrit.ovirt.org:29418/vdsm refs/changes/93/11693/1
diff --git a/vdsm/storage/lvm.py b/vdsm/storage/lvm.py index 148a010..3d33ac8 100644 --- a/vdsm/storage/lvm.py +++ b/vdsm/storage/lvm.py @@ -147,6 +147,23 @@ return filt
+def _cmd_type_1(cmd, devices): + """ + Use only for lvm cluster safe commands. + + These are cmds that not change metadata of an existing VG. + _DON'T_ call this directly or indirectly. + """ + filter = _buildFilter(devices) + conf = LVMCONF_TEMPLATE.replace("locking_type=4", + "locking_type=1") % filter + conf = conf.replace("\n", " ") + finalCmd = [constants.EXT_LVM, cmd[0], "--config", conf] + finalCmd.extend(cmd[1:]) + rc, out, err = misc.execCmd(finalCmd, sudo=True) + return rc, out, err + + def _buildConfig(devList): flt = _buildFilter(chain(devList, USER_DEV_LIST)) conf = _current_lvmconf % flt @@ -672,7 +689,7 @@ cmd.extend(("--metadatasize", metadatasize, "--metadatacopies", "2", "--metadataignore", "y")) cmd.extend(devices) - rc, out, err = _lvminfo.cmd(cmd) + rc, out, err = _cmd_type_1(cmd) return rc, out, err
@@ -884,7 +901,7 @@ # Activate the 1st PV metadata areas cmd = ["pvchange", "--metadataignore", "n"] cmd.append(pvs[0]) - rc, out, err = _lvminfo.cmd(cmd) + rc, out, err = _cmd_type_1(cmd, (pvs[0],)) if rc != 0: raise se.PhysDevInitializationError(pvs[0])
@@ -892,7 +909,7 @@ if initialTag: options.extend(("--addtag", initialTag)) cmd = ["vgcreate"] + options + [vgName] + pvs - rc, out, err = _lvminfo.cmd(cmd) + rc, out, err = _cmd_type_1(cmd, pvs) if rc == 0: _lvminfo._invalidatepvs(pvs) _lvminfo._invalidatevgs(vgName)
-- To view, visit http://gerrit.ovirt.org/11693 To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: newchange Gerrit-Change-Id: I0c62d42936630132722974bcdedd619d13185cde Gerrit-PatchSet: 1 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Eduardo ewarszaw@redhat.com