Dan Kenigsberg has submitted this change and it was merged.
Change subject: fix circular reference of storage pool ......................................................................
fix circular reference of storage pool
master storage domain can not be freed because storage pool refers to it. storage pool can't be freed because upgradeCallback is a partial function which refers to itself, making this a circular reference, using proxy of storage pool instead of real ref in upgradeCallback makes them freeable.
Change-Id: Ie2993b0ad8d85898ca86008f7056973ff493e8de Signed-off-by: Royce Lv lvroyce@linux.vnet.ibm.com --- M vdsm/storage/sp.py 1 file changed, 2 insertions(+), 1 deletion(-)
Approvals: Ayal Baron: Looks good to me, but someone else must approve Royce Lv: Verified Saggi Mizrahi: Looks good to me, but someone else must approve Dan Kenigsberg: Looks good to me, approved
-- To view, visit http://gerrit.ovirt.org/3242 To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: merged Gerrit-Change-Id: Ie2993b0ad8d85898ca86008f7056973ff493e8de Gerrit-PatchSet: 3 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Royce Lv lvroyce@linux.vnet.ibm.com Gerrit-Reviewer: Adam Litke agl@us.ibm.com Gerrit-Reviewer: Ayal Baron abaron@redhat.com Gerrit-Reviewer: Dan Kenigsberg danken@redhat.com Gerrit-Reviewer: Mark Wu wudxw@linux.vnet.ibm.com Gerrit-Reviewer: Royce Lv lvroyce@linux.vnet.ibm.com Gerrit-Reviewer: Saggi Mizrahi smizrahi@redhat.com