Tomas Golembiovsky has posted comments on this change.
Change subject: v2v: Add PipelineProc, pipeline wrapper object ......................................................................
Patch Set 4: Verified+1
(2 comments)
No significant changes, restoring V+1.
https://gerrit.ovirt.org/#/c/62094/3/lib/vdsm/v2v.py File lib/vdsm/v2v.py:
PS3, Line 657:
please make try block as small as possible; place this logging just above i
Done
https://gerrit.ovirt.org/#/c/62094/4/lib/vdsm/v2v.py File lib/vdsm/v2v.py:
Line 700: while monotonic_time() < deadline: Line 701: p.poll() Line 702: if p.returncode is not None: Line 703: break Line 704: time.sleep(1) Small fix pointed out by Vinzenz. I haved moved the sleep after the poll(). It's not a big deal, but it can save some unnecessary sleeps in certain situations. Line 705: else: Line 706: p.wait() Line 707: Line 708: if deadline is not None: