Bala.FA has posted comments on this change.
Change subject: Added getDevicePartedInfo function in supervdsm. ......................................................................
Patch Set 5: (2 inline comments)
.................................................... File tests/parted_utils_tests.py Line 47: os.close(tempFd) As per docs, tempfile.NamedTemporaryFile(delete=false) return file like object using mkstemp(). The returned object has opened fd with mode 'w+b' too. My intention is to have 'free' tempfile for losetup. So tempfile.NamedTemporaryFile(delete=false) dpesn't give any value here.
Line 52: self.assertTrue(rc == 0) I will go with assertEquals() :)
-- To view, visit http://gerrit.ovirt.org/3386 To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment Gerrit-Change-Id: I6388d6c112abf106471223101be495f20f157c66 Gerrit-PatchSet: 5 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Bala.FA barumuga@redhat.com Gerrit-Reviewer: Bala.FA barumuga@redhat.com Gerrit-Reviewer: Dan Kenigsberg danken@redhat.com Gerrit-Reviewer: Mark Wu wudxw@linux.vnet.ibm.com Gerrit-Reviewer: Saggi Mizrahi smizrahi@redhat.com Gerrit-Reviewer: Timothy Asir tjeyasin@redhat.com