Giuseppe Vallarelli has posted comments on this change.
Change subject: Added utility to ensure that files written to the file system happen atomically. ......................................................................
Patch Set 4: I would prefer that you didn't submit this
(1 inline comment)
See comment.
.................................................... File vdsm/utils.py Line 37: import functools Line 38: import stat Line 39: import glob Line 40: from contextlib import contextmanager Line 41: from storage.misc import randomStr You should not depend on storage module. Line 42: Line 43: import ethtool Line 44: Line 45: import constants
-- To view, visit http://gerrit.ovirt.org/7656 To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment Gerrit-Change-Id: Ibecd61d6746231a5a8cb17bad9a3302b01454f27 Gerrit-PatchSet: 4 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Antoni Segura Puimedon asegurap@redhat.com Gerrit-Reviewer: Antoni Segura Puimedon asegurap@redhat.com Gerrit-Reviewer: Dan Kenigsberg danken@redhat.com Gerrit-Reviewer: Giuseppe Vallarelli gvallare@redhat.com Gerrit-Reviewer: Livnat Peer lpeer@redhat.com Gerrit-Reviewer: oVirt Jenkins CI Server