Assaf Muller has posted comments on this change.
Change subject: sourcerouting: fix _getRoute not to include local routes ......................................................................
Patch Set 1:
(1 comment)
http://gerrit.ovirt.org/#/c/27262/1/vdsm/network/sourceroute.py File vdsm/network/sourceroute.py:
Line 110: rmFile(DynamicSourceRoute.getTrackingFilePath(device)) Line 111: Line 112: @staticmethod Line 113: def _getRoutes(table, device): Line 114: routes = [] If a host has hundreds of VLAN devices it would be a shame to iterate through all routes instead of just a specific table. I did not fully understand the issue from the commit message (Dan already touched this), but wouldn't it be possible to continue getting the routes from a specific table, but deal with local routes later on? Line 115: for entry in routeShowTable('all'): Line 116: try: Line 117: route = Route.fromText(entry) Line 118: except ValueError: