Antoni Segura Puimedon has posted comments on this change.
Change subject: netinfo: Retrieve bonding options differing from defaults ......................................................................
Patch Set 5: Code-Review-1
(1 comment)
http://gerrit.ovirt.org/#/c/24456/5/tests/functional/networkTests.py File tests/functional/networkTests.py:
Line 1188: {'nics': nics[1:], Line 1189: 'options': 'mode=4 miimon=9'}) Line 1190: Line 1191: # Check that only the 'miimon' option is different from default Line 1192: self.assertEqual(_getBondingOptions(BONDING_NAME), This should be checked by using the netinfo information inside self.vdsm_net that is automatically updated after each request to vdsm, not by using netinfo. Line 1193: {'miimon': ['9']}) Line 1194: Line 1195: # cleanup Line 1196: networks = dict((NETWORK_NAME + str(num), {'remove': True}) for