Dan Kenigsberg has posted comments on this change.
Change subject: Added getDevicePartedInfo function in supervdsm. ......................................................................
Patch Set 4: I would prefer that you didn't submit this
(6 inline comments)
.................................................... File tests/parted_utils_tests.py Line 45: os.close(tempFd) if you do not use tempFd, there is no much point of using the s variant of mktemp...
Line 49: rc, out, err = utils.execCmd(cmd.split()) it is bad practice to split command line on spaces. assume tempFilePath has a space within. I'd very much prefer that you make cmd a pre-parsed tuple literal.
Line 52: rc, out, err = utils.execCmd(cmd.split(), sudo=True) this requires whomever runs the test to have sudo permissions for losetup. I do not think this is common or safe. We may need to @ValidateRunningAsRoot (or do you have a better solution?)
Line 69: assert not putils.getDevicePartedInfo('/dev/abcdef') self.assertFalse() gives a little bit more information on failure. consider using it and its friends instead of simple "assert".
Line 72: info = putils.getDevicePartedInfo(self.devPath) I did not research into this, but I'm getting info={} here on my f16 box.
Line 95: assert (info['type'] == 'gpt') your parenthesis lack consistency
-- To view, visit http://gerrit.ovirt.org/3386 To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment Gerrit-Change-Id: I6388d6c112abf106471223101be495f20f157c66 Gerrit-PatchSet: 4 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Bala.FA barumuga@redhat.com Gerrit-Reviewer: Bala.FA barumuga@redhat.com Gerrit-Reviewer: Dan Kenigsberg danken@redhat.com Gerrit-Reviewer: Mark Wu wudxw@linux.vnet.ibm.com Gerrit-Reviewer: Saggi Mizrahi smizrahi@redhat.com Gerrit-Reviewer: Timothy Asir tjeyasin@redhat.com