Yaniv Bronhaim has posted comments on this change.
Change subject: lib: logUtils: add devel_warn function
......................................................................
Patch Set 2:
(1 comment)
https://gerrit.ovirt.org/#/c/62209/2/lib/vdsm/logUtils.py
File lib/vdsm/logUtils.py:
Line 254: _devlog = logging.getLogger('devel')
Line 255:
Line 256:
Line 257: def devel_warn(message):
Line 258: if config.getboolean('devel', 'python_warnings_enable'):
This is very ugly we should kill this option instead.
i guess we shouldn't want this config value if we don't use the broken python warning module anymore
--
To view, visit
https://gerrit.ovirt.org/62209
To unsubscribe, visit
https://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I5061e78dde7aceffce9ae90fe5e2c2ad8c00f886
Gerrit-PatchSet: 2
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Francesco Romani
fromani@redhat.com
Gerrit-Reviewer: Adam Litke
alitke@redhat.com
Gerrit-Reviewer: Dan Kenigsberg
danken@redhat.com
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Nir Soffer
nsoffer@redhat.com
Gerrit-Reviewer: Piotr Kliczewski
piotr.kliczewski@gmail.com
Gerrit-Reviewer: Yaniv Bronhaim
ybronhei@redhat.com
Gerrit-Reviewer: gerrit-hooks
automation@ovirt.org
Gerrit-HasComments: Yes