Wenyi Gao has posted comments on this change.
Change subject: Close and remove the temporary file before raising a exception ......................................................................
Patch Set 1: (2 inline comments)
.................................................... File vdsm/storage/multipath.py Line 116: supported state. The original configuration, if any, is saved Yes, it seems to make sense.
Line 121: f.write(MPATH_CONF_TEMPLATE) Good, suggestion.
-- To view, visit http://gerrit.ovirt.org/4885 To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment Gerrit-Change-Id: I93eafbcf78805669596258b3579ee49cc1b79360 Gerrit-PatchSet: 1 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Wenyi Gao wenyi@linux.vnet.ibm.com Gerrit-Reviewer: Adam Litke agl@us.ibm.com Gerrit-Reviewer: Dan Kenigsberg danken@redhat.com Gerrit-Reviewer: Federico Simoncelli fsimonce@redhat.com Gerrit-Reviewer: Ryan Harper ryanh@us.ibm.com Gerrit-Reviewer: Saggi Mizrahi smizrahi@redhat.com Gerrit-Reviewer: Shu Ming shuming@linux.vnet.ibm.com Gerrit-Reviewer: Wenyi Gao wenyi@linux.vnet.ibm.com