Eduardo has uploaded a new change for review.
Change subject: BZ#782348 - Fix getBridgeParams() ......................................................................
BZ#782348 - Fix getBridgeParams()
Blank lines are valid in /etc/sysconfig/network-scripts/ifcfg-ethX
Change-Id: Ic3f40d235fc63b727472c2f250a65755d1aa7791 --- M vdsm_reg/deployUtil.py.in 1 file changed, 4 insertions(+), 4 deletions(-)
git pull ssh://gerrit.ovirt.org:29418/vdsm refs/changes/02/1102/1 -- To view, visit http://gerrit.ovirt.org/1102 To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: newchange Gerrit-Change-Id: Ic3f40d235fc63b727472c2f250a65755d1aa7791 Gerrit-PatchSet: 1 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Eduardo ewarszaw@redhat.com
Ayal Baron has posted comments on this change.
Change subject: BZ#782348 - Fix getBridgeParams() ......................................................................
Patch Set 2: Looks good to me, but someone else must approve
-- To view, visit http://gerrit.ovirt.org/1102 To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment Gerrit-Change-Id: Ic3f40d235fc63b727472c2f250a65755d1aa7791 Gerrit-PatchSet: 2 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Eduardo ewarszaw@redhat.com Gerrit-Reviewer: Ayal Baron abaron@redhat.com Gerrit-Reviewer: Eduardo ewarszaw@redhat.com Gerrit-Reviewer: Haim Ateya hateya@redhat.com
Haim Ateya has posted comments on this change.
Change subject: BZ#782348 - Fix getBridgeParams() ......................................................................
Patch Set 2: Verified
-- To view, visit http://gerrit.ovirt.org/1102 To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment Gerrit-Change-Id: Ic3f40d235fc63b727472c2f250a65755d1aa7791 Gerrit-PatchSet: 2 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Eduardo ewarszaw@redhat.com Gerrit-Reviewer: Ayal Baron abaron@redhat.com Gerrit-Reviewer: Eduardo ewarszaw@redhat.com Gerrit-Reviewer: Haim Ateya hateya@redhat.com
Dan Kenigsberg has posted comments on this change.
Change subject: BZ#782348 - Fix getBridgeParams() ......................................................................
Patch Set 2: Looks good to me, approved
-- To view, visit http://gerrit.ovirt.org/1102 To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment Gerrit-Change-Id: Ic3f40d235fc63b727472c2f250a65755d1aa7791 Gerrit-PatchSet: 2 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Eduardo ewarszaw@redhat.com Gerrit-Reviewer: Ayal Baron abaron@redhat.com Gerrit-Reviewer: Dan Kenigsberg danken@redhat.com Gerrit-Reviewer: Eduardo ewarszaw@redhat.com Gerrit-Reviewer: Haim Ateya hateya@redhat.com
Dan Kenigsberg has submitted this change and it was merged.
Change subject: BZ#782348 - Fix getBridgeParams() ......................................................................
BZ#782348 - Fix getBridgeParams()
Blank lines are valid in /etc/sysconfig/network-scripts/ifcfg-ethX
Change-Id: Ic3f40d235fc63b727472c2f250a65755d1aa7791 --- M vdsm_reg/deployUtil.py.in 1 file changed, 4 insertions(+), 4 deletions(-)
Approvals: Ayal Baron: Looks good to me, but someone else must approve Haim Ateya: Verified Dan Kenigsberg: Looks good to me, approved
-- To view, visit http://gerrit.ovirt.org/1102 To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: merged Gerrit-Change-Id: Ic3f40d235fc63b727472c2f250a65755d1aa7791 Gerrit-PatchSet: 2 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Eduardo ewarszaw@redhat.com Gerrit-Reviewer: Ayal Baron abaron@redhat.com Gerrit-Reviewer: Dan Kenigsberg danken@redhat.com Gerrit-Reviewer: Eduardo ewarszaw@redhat.com Gerrit-Reviewer: Haim Ateya hateya@redhat.com
vdsm-patches@lists.fedorahosted.org