Dan Kenigsberg has uploaded a new change for review.
Change subject: iscsi.py: fixed discovery issue and added support for iSER transport ......................................................................
iscsi.py: fixed discovery issue and added support for iSER transport
Fixed discovery of targets not to overwrite settings of already connected targets. Added support for iSER transport.
Change-Id: I1012219f5202882db62743e5f2cf5cbcaaca930a --- M vdsm/storage/iscsi.py 1 file changed, 39 insertions(+), 5 deletions(-)
git pull ssh://gerrit.ovirt.org:29418/vdsm refs/changes/05/905/1 -- To view, visit http://gerrit.ovirt.org/905 To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: newchange Gerrit-Change-Id: I1012219f5202882db62743e5f2cf5cbcaaca930a Gerrit-PatchSet: 1 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Dan Kenigsberg danken@redhat.com
Douglas Schilling Landgraf has posted comments on this change.
Change subject: iscsi.py: fixed discovery issue and added support for iSER transport ......................................................................
Patch Set 1: Looks good to me, but someone else must approve
-- To view, visit http://gerrit.ovirt.org/905 To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment Gerrit-Change-Id: I1012219f5202882db62743e5f2cf5cbcaaca930a Gerrit-PatchSet: 1 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Dan Kenigsberg danken@redhat.com Gerrit-Reviewer: Douglas Schilling Landgraf dougsland@redhat.com Gerrit-Reviewer: Roi Dayan roi.dayan@gmail.com
Dan Kenigsberg has posted comments on this change.
Change subject: iscsi.py: fixed discovery issue and added support for iSER transport ......................................................................
Patch Set 1: I would prefer that you didn't submit this
(4 inline comments)
.................................................... File vdsm/storage/iscsi.py Line 37: SENDTARGETS_DISCOVERY = [constants.EXT_ISCSIADM, "-m", "discoverydb", "-t", "sendtargets", "-o", "new", "-o", "delete"] please keep new code shorter than 80 chars.
Line 257: setNodeTransport(portal, iqn, 'iser') attempted transports should be take from config. most users should not try iser and fail, if they care only about tcp.
Line 259: rc = misc.execCmd(cmd)[0] if vdsm dies here, host is stuck in iser mode. I do not like that. Please make iscsiadm accept the transport in its command line.
Line 261: if rc == ISCSI_ERR_LOGIN_AUTH_FAILED: no tabs, please.
-- To view, visit http://gerrit.ovirt.org/905 To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment Gerrit-Change-Id: I1012219f5202882db62743e5f2cf5cbcaaca930a Gerrit-PatchSet: 1 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Dan Kenigsberg danken@redhat.com Gerrit-Reviewer: Dan Kenigsberg danken@redhat.com Gerrit-Reviewer: Douglas Schilling Landgraf dougsland@redhat.com Gerrit-Reviewer: Roi Dayan roi.dayan@gmail.com
Dan Kenigsberg has abandoned this change.
Change subject: iscsi.py: fixed discovery issue and added support for iSER transport ......................................................................
Patch Set 1: Abandoned
preceded by http://gerrit.ovirt.org/1350
-- To view, visit http://gerrit.ovirt.org/905 To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: abandon Gerrit-Change-Id: I1012219f5202882db62743e5f2cf5cbcaaca930a Gerrit-PatchSet: 1 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Dan Kenigsberg danken@redhat.com Gerrit-Reviewer: Dan Kenigsberg danken@redhat.com Gerrit-Reviewer: Douglas Schilling Landgraf dougsland@redhat.com Gerrit-Reviewer: Roi Dayan roi.dayan@gmail.com
vdsm-patches@lists.fedorahosted.org