Change in vdsm[master]: Improve usage for bridgeless network

Lei Li has uploaded a new change for review.

Change subject: Improve usage for bridgeless network
......................................................................

Improve usage for bridgeless network

The usage of add/del network is still for bridge only network,
It is useless and may cause confusion. So change it to keep
consistence with current network.

Change-Id: I4f03f9a331062adc662d22ef4ad5a5b582a07835
Signed-off-by: Lei Li 
---
M vdsm/configNetwork.py
1 file changed, 5 insertions(+), 5 deletions(-)

git pull ssh://gerrit.ovirt.org:29418/vdsm refs/changes/64/3664/1
--
To view, visit http://gerrit.ovirt.org/3664
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: newchange
Gerrit-Change-Id: I4f03f9a331062adc662d22ef4ad5a5b582a07835
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Lei Li

[Dan Kenigsberg]

Dan Kenigsberg has posted comments on this change.

Change subject: Improve usage for bridgeless network
......................................................................

Patch Set 1: Looks good to me, but someone else must approve

--
To view, visit http://gerrit.ovirt.org/3664
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I4f03f9a331062adc662d22ef4ad5a5b582a07835
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Lei Li 
Gerrit-Reviewer: Adam Litke 
Gerrit-Reviewer: Dan Kenigsberg 
Gerrit-Reviewer: Shahar Havivi

Mark Wu has posted comments on this change.

Change subject: Improve usage for bridgeless network
......................................................................

Patch Set 1: I would prefer that you didn't submit this

(2 inline comments)

....................................................
File vdsm/configNetwork.py
Line 1043:     ./configNetwork.py add Network <attributes> <options>
A minor suggestion,  "network" is better than "Network" for me.

Line 1046:                        setup Network [None|attributes] [++ bridge [None|attributes] [++ ...]] [:: <options>]
You forgot to change the second "bridge".

--
To view, visit http://gerrit.ovirt.org/3664
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I4f03f9a331062adc662d22ef4ad5a5b582a07835
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Lei Li 
Gerrit-Reviewer: Adam Litke 
Gerrit-Reviewer: Dan Kenigsberg 
Gerrit-Reviewer: Mark Wu 
Gerrit-Reviewer: Shahar Havivi

Lei Li has posted comments on this change.

Change subject: Improve usage for bridgeless network
......................................................................

Patch Set 1: (2 inline comments)

....................................................
File vdsm/configNetwork.py
Line 1043:     ./configNetwork.py add Network <attributes> <options>
I would prefer Network... :)

Line 1046:                        setup Network [None|attributes] [++ bridge [None|attributes] [++ ...]] [:: <options>]
Thanks! I forgot change this one... I will update it later

--
To view, visit http://gerrit.ovirt.org/3664
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I4f03f9a331062adc662d22ef4ad5a5b582a07835
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Lei Li 
Gerrit-Reviewer: Adam Litke 
Gerrit-Reviewer: Dan Kenigsberg 
Gerrit-Reviewer: Lei Li 
Gerrit-Reviewer: Mark Wu 
Gerrit-Reviewer: Shahar Havivi

Mark Wu has posted comments on this change.

Change subject: Improve usage for bridgeless network
......................................................................

Patch Set 2: Looks good to me, but someone else must approve

--
To view, visit http://gerrit.ovirt.org/3664
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I4f03f9a331062adc662d22ef4ad5a5b582a07835
Gerrit-PatchSet: 2
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Lei Li 
Gerrit-Reviewer: Adam Litke 
Gerrit-Reviewer: Dan Kenigsberg 
Gerrit-Reviewer: Lei Li 
Gerrit-Reviewer: Mark Wu 
Gerrit-Reviewer: Shahar Havivi

Dmitry Fleytman has posted comments on this change.

Change subject: Improve usage for bridgeless network
......................................................................

Patch Set 2: Verified; Looks good to me, but someone else must approve

--
To view, visit http://gerrit.ovirt.org/3664
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I4f03f9a331062adc662d22ef4ad5a5b582a07835
Gerrit-PatchSet: 2
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Lei Li 
Gerrit-Reviewer: Adam Litke 
Gerrit-Reviewer: Dan Kenigsberg 
Gerrit-Reviewer: Dmitry Fleytman 
Gerrit-Reviewer: Lei Li 
Gerrit-Reviewer: Mark Wu 
Gerrit-Reviewer: Shahar Havivi

[Igor Lvovsky]

Igor Lvovsky has posted comments on this change.

Change subject: Improve usage for bridgeless network
......................................................................

Patch Set 2: Looks good to me, approved

--
To view, visit http://gerrit.ovirt.org/3664
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I4f03f9a331062adc662d22ef4ad5a5b582a07835
Gerrit-PatchSet: 2
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Lei Li 
Gerrit-Reviewer: Adam Litke 
Gerrit-Reviewer: Dan Kenigsberg 
Gerrit-Reviewer: Dmitry Fleytman 
Gerrit-Reviewer: Igor Lvovsky 
Gerrit-Reviewer: Lei Li 
Gerrit-Reviewer: Mark Wu 
Gerrit-Reviewer: Shahar Havivi

[Igor Lvovsky]

Igor Lvovsky has submitted this change and it was merged.

Change subject: Improve usage for bridgeless network
......................................................................

Improve usage for bridgeless network

The usage of add/del network is still for bridge only network,
It is useless and may cause confusion. So change it to keep
consistence with current network.

Change-Id: I4f03f9a331062adc662d22ef4ad5a5b582a07835
Signed-off-by: Lei Li 
---
M vdsm/configNetwork.py
1 file changed, 5 insertions(+), 5 deletions(-)

Approvals:
  Dmitry Fleytman: Verified; Looks good to me, but someone else must approve
  Mark Wu: Looks good to me, but someone else must approve
  Igor Lvovsky: Looks good to me, approved

--
To view, visit http://gerrit.ovirt.org/3664
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: merged
Gerrit-Change-Id: I4f03f9a331062adc662d22ef4ad5a5b582a07835
Gerrit-PatchSet: 2
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Lei Li 
Gerrit-Reviewer: Adam Litke 
Gerrit-Reviewer: Dan Kenigsberg 
Gerrit-Reviewer: Dmitry Fleytman 
Gerrit-Reviewer: Igor Lvovsky 
Gerrit-Reviewer: Lei Li 
Gerrit-Reviewer: Mark Wu 
Gerrit-Reviewer: Shahar Havivi