Change in vdsm[master]: [WIP] add before_vm_destroy hook

[Dan Kenigsberg]

Dan Kenigsberg has uploaded a new change for review.

Change subject: [WIP] add before_vm_destroy hook
......................................................................

[WIP] add before_vm_destroy hook

Run a hook directory when a Vm is asked to die. Note that a Vm may die
without being asked to, were the hook would not run.

This hook is currently missing from Vdsm since I was not sure what
should be its exact semantic. However in hindsight, we'd better have
something (even awkward) and improve after feedback from the real world.

Change-Id: Ide2c143921e58944df97c3dc74cd20cd85b1dae8
---
M vdsm.spec.in
M vdsm/hooks.py
M vdsm/libvirtvm.py
M vdsm/vdsmd.8.in
4 files changed, 10 insertions(+), 2 deletions(-)

git pull ssh://gerrit.ovirt.org:29418/vdsm refs/changes/75/1175/1
--
To view, visit http://gerrit.ovirt.org/1175
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: newchange
Gerrit-Change-Id: Ide2c143921e58944df97c3dc74cd20cd85b1dae8
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Dan Kenigsberg

Shahar Havivi has posted comments on this change.

Change subject: [WIP] add before_vm_destroy hook
......................................................................

Patch Set 1: Looks good to me, but someone else must approve

--
To view, visit http://gerrit.ovirt.org/1175
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Ide2c143921e58944df97c3dc74cd20cd85b1dae8
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Dan Kenigsberg 
Gerrit-Reviewer: Shahar Havivi

Shahar Havivi has posted comments on this change.

Change subject: [WIP] add before_vm_destroy hook
......................................................................

Patch Set 1: I would prefer that you didn't submit this

you are missing the mkdir before_vm_destory in vdsm_hooks/Makefile.am

I will send a patch

--
To view, visit http://gerrit.ovirt.org/1175
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Ide2c143921e58944df97c3dc74cd20cd85b1dae8
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Dan Kenigsberg 
Gerrit-Reviewer: Shahar Havivi

Shahar Havivi has posted comments on this change.

Change subject: [WIP] add before_vm_destroy hook
......................................................................

Patch Set 1: Verified

(1 inline comment)

....................................................
File vdsm/libvirtvm.py
Line 1489:         hooks.before_vm_destroy(self._vm._dom.XMLDesc(0), self._vm.conf)
_vm is not a member of libvirtVm

--
To view, visit http://gerrit.ovirt.org/1175
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Ide2c143921e58944df97c3dc74cd20cd85b1dae8
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Dan Kenigsberg 
Gerrit-Reviewer: Shahar Havivi

Shahar Havivi has posted comments on this change.

Change subject: [WIP] add before_vm_destroy hook
......................................................................

Patch Set 2: Verified

--
To view, visit http://gerrit.ovirt.org/1175
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Ide2c143921e58944df97c3dc74cd20cd85b1dae8
Gerrit-PatchSet: 2
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Dan Kenigsberg 
Gerrit-Reviewer: Shahar Havivi

Change in vdsm[master]: Add before_vm_destroy hook

Shahar Havivi has posted comments on this change.

Change subject: Add before_vm_destroy hook
......................................................................

Patch Set 3: Looks good to me, but someone else must approve

--
To view, visit http://gerrit.ovirt.org/1175
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Ide2c143921e58944df97c3dc74cd20cd85b1dae8
Gerrit-PatchSet: 3
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Dan Kenigsberg 
Gerrit-Reviewer: Shahar Havivi

Change in vdsm[master]: Add before_vm_destroy hook

[Douglas Schilling Landgraf]

Douglas Schilling Landgraf has posted comments on this change.

Change subject: Add before_vm_destroy hook
......................................................................

Patch Set 3: Looks good to me, but someone else must approve

--
To view, visit http://gerrit.ovirt.org/1175
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Ide2c143921e58944df97c3dc74cd20cd85b1dae8
Gerrit-PatchSet: 3
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Dan Kenigsberg 
Gerrit-Reviewer: Douglas Schilling Landgraf 
Gerrit-Reviewer: Shahar Havivi

Change in vdsm[master]: Add before_vm_destroy hook

[Dan Kenigsberg]

Dan Kenigsberg has posted comments on this change.

Change subject: Add before_vm_destroy hook
......................................................................

Patch Set 4: Verified; Looks good to me, approved

rebased

--
To view, visit http://gerrit.ovirt.org/1175
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Ide2c143921e58944df97c3dc74cd20cd85b1dae8
Gerrit-PatchSet: 4
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Dan Kenigsberg 
Gerrit-Reviewer: Dan Kenigsberg 
Gerrit-Reviewer: Douglas Schilling Landgraf 
Gerrit-Reviewer: Shahar Havivi

Change in vdsm[master]: Add before_vm_destroy hook

[Dan Kenigsberg]

Dan Kenigsberg has submitted this change and it was merged.

Change subject: Add before_vm_destroy hook
......................................................................

Add before_vm_destroy hook

Run a hook directory when a Vm is asked to die. Note that a Vm may die
without being asked to, were the hook would not run.

This hook is currently missing from Vdsm since I was not sure what
should be its exact semantic. However in hindsight, we'd better have
something (even awkward) and improve after feedback from the real world.

Change-Id: Ide2c143921e58944df97c3dc74cd20cd85b1dae8
---
M vdsm.spec.in
M vdsm/hooks.py
M vdsm/libvirtvm.py
M vdsm/vdsmd.8.in
M vdsm_hooks/Makefile.am
5 files changed, 11 insertions(+), 2 deletions(-)

Approvals:
  Dan Kenigsberg: Verified; Looks good to me, approved

--
To view, visit http://gerrit.ovirt.org/1175
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: merged
Gerrit-Change-Id: Ide2c143921e58944df97c3dc74cd20cd85b1dae8
Gerrit-PatchSet: 4
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Dan Kenigsberg 
Gerrit-Reviewer: Dan Kenigsberg 
Gerrit-Reviewer: Douglas Schilling Landgraf 
Gerrit-Reviewer: Shahar Havivi